Skip to content

Conversation

@r-recchia
Copy link
Contributor

@r-recchia r-recchia commented Oct 30, 2025

Summary

Testing

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces named pipe communication for the OTA provider application, enabling external control, and adds a new Python test (TC_SU_2_8.py) for multi-fabric OTA scenarios. The changes span C++ and Python, modifying the OTA provider, adding new test infrastructure, and implementing the test case. My review has identified several issues, including a bug in the pipe cleanup logic, an unused variable in the C++ command handler, and incorrect API usage in the new Python test and its helper functions. Additionally, there is some commented-out code that should be removed for clarity. The comments regarding create_acl_entry in apps.py and apps.pyi have been removed as they refer to a type hint file update, which is outside the scope of code changes.

@mergify mergify bot removed the conflict label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

PR #41708: Size comparison from 1089161 to 1297b97

Full report (5 builds for cc32xx, realtek, stm32)
platform target config section 1089161 1297b97 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554906 554906 0 0.0
RAM 205776 205776 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587786 587786 0 0.0
RAM 205872 205872 0 0.0
realtek light-switch-app rtl8777g FLASH 706952 706952 0 0.0
RAM 106964 106964 0 0.0
lighting-app rtl8777g FLASH 757896 757896 0 0.0
RAM 127296 127296 0 0.0
stm32 light STM32WB5MM-DK FLASH 470224 470224 0 0.0
RAM 141352 141352 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant