[DRAFT] Unified build more apps #41765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… testing framework - Added `is_commissioned` and `get_commissioned_fabric_count` functions to check device commissioning status. - Introduced `require_factory_reset` and `skip_if_commissioned` decorators to enforce factory-fresh state for tests. - Updated `assert_factory_fresh` and `assert_is_commissioned` assertions for better validation of device state. - Refactored `TC_SC_7_1` test to utilize new commissioning helper for verifying factory reset status. These changes enhance the testing framework's ability to ensure devices are in the correct state before running tests.
…kflow - Corrected typos in target names for microwave oven and energy gateway in the GitHub Actions workflow. - Updated the build script to support unified builds for additional targets, including Python bindings and triggers. - Refactored the builder classes to manage unified build identifiers and output directories more effectively.
…ntoTargetParts method
… and ninja_jobs parameters to improve build configuration options.
…name and repository path parameters for improved context management.
… builders and update artifact naming to include target names for improved clarity.
- Introduced a private _output_dir attribute to store the output directory. - Added a getter and setter for output_dir to manage the output directory more effectively. - This enhancement improves flexibility in specifying output paths for builds.
…path directly, enhancing context management for target creation.
…t name and repository path, improving context management for target creation.
…and improve clarity - Removed unnecessary pre-build command call. - Simplified command construction for ninja jobs and build commands. - Enhanced title generation to include target information when applicable.
…nvironment handling - Introduced pre-build command execution for better preparation. - Improved command construction for ninja jobs and environment variables. - Updated title generation to conditionally include target information based on build command.
- Removed conditional title generation based on build command. - Streamlined command execution by directly using the identifier for the title. - Enhanced clarity in the build process by reducing complexity in title management.
|
PR #41765: Size comparison from 1223307 to 371a36a Full report (17 builds for efr32, esp32, nrfconnect, nxp, qpg, stm32, telink)
|
…t warnings condition - Updated the condition for applying linker flags to exclude thread sanitizer (tsan) in addition to address sanitizer (asan) for Linux and Android platforms. - Improved clarity in the build process by ensuring stricter warnings are only applied when neither sanitizer is active.
|
PR #41765: Size comparison from 1223307 to 4e43208 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
- Introduced a call to start command execution at the beginning of the Generate method. - This change enhances the command execution flow within the build process.
|
PR #41765: Size comparison from 1223307 to 9f215b8 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
- Imported tracing_args.gni in the BUILD.gn files for chip-tool, chip-shell, and integration tests. - Added conditional dependencies for tracing support based on the matter_enable_tracing_support flag. - This enhancement allows for improved tracing capabilities in the respective components.
… integration tests
- Changed the dependency from "${chip_root}/src/tracing" to "${chip_root}/src/tracing:macros" in the BUILD.gn files for chip-tool, chip-shell, and integration tests.
- This modification ensures that the correct tracing macros are included when tracing support is enabled.
|
PR #41765: Size comparison from 1223307 to fdd32a1 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, realtek, stm32)
|
…and configurations - Added new build targets for Linux architecture, including various applications and configurations. - Enhanced the existing target list to improve build flexibility and support for additional features.
|
PR #41765: Size comparison from 1223307 to 6a20697 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
- Updated dependencies in the BUILD.gn files to include additional tracing components: "${chip_root}/src/tracing/perfetto" and "${chip_root}/src/tracing/perfetto:simple_initialization".
- This change ensures comprehensive tracing capabilities when tracing support is enabled.
|
PR #41765: Size comparison from 1223307 to 748d620 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
… tests
- Modified the BUILD.gn files to change the dependency for tracing from "${chip_root}/src/tracing/perfetto" to "${chip_root}/src/tracing/perfetto:perfetto".
- This adjustment ensures the correct tracing components are referenced when tracing support is enabled.
|
PR #41765: Size comparison from 1223307 to e998608 Full report (6 builds for cc32xx, nrfconnect, realtek, stm32)
|
…on tests - Updated the BUILD.gn files to conditionally include Perfetto dependencies based on the operating system, ensuring they are only added for Linux and Android. - This change simplifies the dependency management for tracing support while maintaining compatibility across platforms.
|
PR #41765: Size comparison from 1223307 to 7c64904 Full report (32 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
…on tests - Eliminated the import of tracing_args.gni and conditional tracing dependencies from the BUILD.gn files for chip-tool, chip-shell, and integration tests. - This change simplifies the build configuration by removing unnecessary tracing support, while retaining the core functionality of the components.
…ests - Reintroduced the import of tracing_args.gni and added conditional dependencies for tracing support based on the matter_enable_tracing_support flag. - Updated the BUILD.gn files to include Perfetto dependencies only for Linux and Android, ensuring proper tracing capabilities while maintaining cross-platform compatibility.
|
PR #41765: Size comparison from 1223307 to 62fd174 Full report (3 builds for realtek, stm32)
|
|
PR #41765: Size comparison from 7bad8a9 to caf0219 Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
- Removed 'energy-management' and 'network-manager' from the BuildHostTarget function. - Added 'fabric-bridge' to the target list. - Introduced new unified groups for apps that disable read_client and for apps with strict TLV validation, enhancing build configuration flexibility. - Updated all_targets_linux_x64.txt to reflect the changes in target definitions.
|
PR #41765: Size comparison from 7bad8a9 to 47bbdc2 Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
- Added new targets for 'energy-gateway', 'energy-management', 'camera-controller', 'jf-admin-app', and 'terms-and-conditions' under appropriate unified build groups. - Updated the build scripts to reflect changes in target definitions, including the removal of obsolete targets. - Adjusted the output paths in the environment file generation to match the new target structure. - Improved the overall organization of the build process by consolidating related targets into unified groups.
|
PR #41765: Size comparison from 7bad8a9 to 4cdfcf8 Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
- Eliminated 'fabric-bridge' from the target list in both the GitHub Actions workflow and the build script. - This change streamlines the build process by removing an obsolete target, ensuring a more focused and efficient build configuration.
…' apps in build script - Introduced 'all-clusters' and 'energy-gateway' targets under the 'no-read-client' unified group. - Added new targets for 'camera-controller', 'fabric-admin', and 'jf-control' under the 'strict-tlv' unified group. - Updated the target definitions to enhance build configuration flexibility and organization.
|
PR #41765: Size comparison from 7bad8a9 to b2885e6 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
- Reintroduced 'all-clusters' and 'energy-gateway' targets in the GitHub Actions workflow, enhancing build capabilities. - Updated output paths in the environment file generation to align with the new target structure. - Removed obsolete targets from the build scripts, improving overall organization and efficiency of the build process.
|
PR #41765: Size comparison from 7bad8a9 to fba221c Full report (22 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
- Eliminated 'python-bindings' from the target list in the GitHub Actions workflow and the build script. - This change streamlines the build process by removing an obsolete target, ensuring a more focused and efficient build configuration.
|
PR #41765: Size comparison from 7bad8a9 to 083e0f4 Full report (16 builds for cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32)
|
…target - Removed the 'terms-and-conditions' target from the build script and workflow, streamlining the build process. - Added back the 'terms-and-conditions' target in the GitHub Actions workflow with updated build commands. - Adjusted output paths in the environment file generation to reflect the new target structure, ensuring consistency in the build process.
|
PR #41765: Size comparison from 7bad8a9 to ca8852d Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines