Skip to content

Conversation

@chrisdecenzo
Copy link
Contributor

Summary

Currently there is no callback to higher layer when commissioning attempt fails due to bad passcode

Testing

Manually test on android

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a callback mechanism to handle commissioning failures, such as those from an incorrect passcode, by implementing the AppDelegate interface in CastingPlayer. The changes are logical and effectively address the problem described. My review focuses on improving the robustness of this new mechanism by preventing potential race conditions and ensuring consistent state management upon connection failure or termination.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

PR #41802: Size comparison from 6251801 to b3b9886

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 6251801 b3b9886 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1106380 1106380 0 0.0
RAM 178930 178930 0 0.0
bl702 lighting-app bl702+eth FLASH 661414 661414 0 0.0
RAM 135025 135025 0 0.0
bl702+wifi FLASH 837048 837048 0 0.0
RAM 124445 124445 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070586 1070586 0 0.0
RAM 117317 117317 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 900018 900018 0 0.0
RAM 105612 105612 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983332 983332 0 0.0
RAM 109796 109796 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770812 770812 0 0.0
RAM 103360 103360 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 782640 782640 0 0.0
RAM 108528 108528 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728588 728588 0 0.0
RAM 97420 97420 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 713056 713056 0 0.0
RAM 97636 97636 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554906 554906 0 0.0
RAM 205776 205776 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587786 587786 0 0.0
RAM 205872 205872 0 0.0
efr32 lock-app BRD4187C FLASH 963472 963472 0 0.0
RAM 123572 123572 0 0.0
BRD4338a FLASH 757808 757808 0 0.0
RAM 254196 254196 0 0.0
window-app BRD4187C FLASH 1058828 1058828 0 0.0
RAM 119800 119800 0 0.0
esp32 all-clusters-app c3devkit DRAM 102572 102572 0 0.0
FLASH 1836750 1836750 0 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 933432 933432 0 0.0
RAM 161377 161377 0 0.0
nxp contact mcxw71+release FLASH 692520 692520 0 0.0
RAM 61552 61552 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1678164 1678164 0 0.0
RAM 213956 213956 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1594548 1594548 0 0.0
RAM 211156 211156 0 0.0
light cy8ckit_062s2_43012 FLASH 1460772 1460772 0 0.0
RAM 197776 197776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1493460 1493460 0 0.0
RAM 225496 225496 0 0.0
qpg lighting-app qpg6200+debug FLASH 837744 837744 0 0.0
RAM 127768 127768 0 0.0
lock-app qpg6200+debug FLASH 774572 774572 0 0.0
RAM 118736 118736 0 0.0
realtek light-switch-app rtl8777g FLASH 706928 706928 0 0.0
RAM 106964 106964 0 0.0
lighting-app rtl8777g FLASH 757864 757864 0 0.0
RAM 127296 127296 0 0.0
stm32 light STM32WB5MM-DK FLASH 470256 470256 0 0.0
RAM 141352 141352 0 0.0
telink bridge-app tl7218x FLASH 710646 710646 0 0.0
RAM 90600 90600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 797120 797120 0 0.0
RAM 41024 41024 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 788322 788322 0 0.0
RAM 93700 93700 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715324 715324 0 0.0
RAM 51892 51892 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748620 748620 0 0.0
RAM 70932 70932 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725474 725474 0 0.0
RAM 34624 34624 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602752 602752 0 0.0
RAM 108928 108928 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820956 820960 4 0.0
RAM 92096 92096 0 0.0

@mergify mergify bot merged commit d5774d6 into project-chip:master Nov 6, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants