-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add callback on passcode error #41802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a callback mechanism to handle commissioning failures, such as those from an incorrect passcode, by implementing the AppDelegate interface in CastingPlayer. The changes are logical and effectively address the problem described. My review focuses on improving the robustness of this new mechanism by preventing potential race conditions and ensuring consistent state management upon connection failure or termination.
|
PR #41802: Size comparison from 6251801 to b3b9886 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Summary
Currently there is no callback to higher layer when commissioning attempt fails due to bad passcode
Testing
Manually test on android