Fix typo in Ids.h generator. #41826
Merged
Fix typo in Ids.h generator. #41826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Nov 6, 2025
andy31415
added
the
sdk-maintainer-approved
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a formatting bug in the Jinja template used to generate cluster ID header files. The template was incorrectly using 0x04%X instead of 0x%04X, which resulted in hexadecimal cluster codes being prefixed with an erroneous "4" instead of being properly zero-padded to 4 digits.
- Corrects the format string in the Jinja template from
0x04%Xto0x%04X - Regenerates all affected cluster ID header files with the corrected hex format
Reviewed Changes
Copilot reviewed 143 out of 143 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/py_matter_idl/matter/idl/generators/cpp/sdk/Ids.h.jinja | Fixes the format string to properly zero-pad hex values instead of adding an erroneous "4" prefix |
| zzz_generated/app-common/clusters/*/Ids.h (multiple files) | Regenerated files with corrected hexadecimal cluster code formatting |
|
PR #41826: Size comparison from bc6337d to be2d8ed Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small change to fix a typo in the
Ids.h.jinjafile that is used to generate theIds.hfiles for each cluster.This typo caused that and additional "4" was added to each cluster hex code in the file header, this only affects the comment and code remains unchanged.
Testing
CI should validate, change only affects comments so no functional change is expected.