Add nullptr checks in ContentAppPlatform mContentAppFactory #41827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional checks inside ContentAppPlatform to first check if mContentAppFactory is null to prevent nullptr dereference crashes. [Problem] There are several dereferences to mContentAppFactory without first checking if pointer is valid.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds necessary nullptr checks for mContentAppFactory in several methods within ContentAppPlatform.cpp. These changes are crucial for preventing potential nullptr dereference crashes, thereby improving the robustness and stability of the application platform. The added checks are correctly implemented using the appropriate VerifyOrReturnValue and VerifyOrReturnError macros, ensuring that the functions fail gracefully if mContentAppFactory is not initialized. The changes are clear, correct, and effectively address the identified issue.
|
PR #41827: Size comparison from bc6337d to 2588315 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add additional checks inside ContentAppPlatform to first check if mContentAppFactory is null to prevent nullptr dereference crashes.
Related issues
[Problem]
There are several dereferences to mContentAppFactory without first checking if pointer is valid.