-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Python wheels: Create one wheel to rule them all #41832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
We are working towards launching a python support module on PyPI to support local testing for developers who do not work day-to-day on the SDK and would prefer to just pip install a package. This package contains a single wheel that encompases the following individual wheel files from the SDK - matter-core - matter-clusters - matter-repl - matter-idl - matter-yamltest - matter-testing matter-jupiter will be added in a subsequent PR. The three core matter wheel files are currently being compiled by a secondary script. I opted to keep this in place for this PR to avoid complicating changes, but we should be able to remove the duplication in a follow up and compile the -core, -clusters and -repl wheel files through pigweed for simpliciy. This PR aims just to match the current python environment setup and therefore still requires that the test scripts themselves be provided. This is another follow up, as is integration of the mdns into the testing framework and inclusion of the support files like the certificates. A CI test will be added to this PR in a subsequent commit. Follow up summary for this PR: - CI to 1) create raw venv 2) install from combined wheel 3) run at least one tests (that uses data_model) Follow up summary: - CI job to manual push to test PyPI - add jupiter - change -core -clusters -repl to use pw build files - add mdns files to matter-testing - add an additional wheel to bundle the tests and the certs - examine swapping the CI over to pip install
| deps = [ | ||
| "${chip_root}/scripts:matter_yamltests_distribution.wheel", | ||
| "${chip_root}/scripts/py_matter_yamltests:matter-yamltests.wheel", | ||
| "${chip_root}/src/controller/python:matter-core-module.wheel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up for me - either add all the -core -cluster -repl ones here or remove this line
| } | ||
| } | ||
|
|
||
| if (chip_support_commissioning_in_controller) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do? Should python not always look the same (and maybe always be ctrl)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a way to compile the python stuff to support a python-based server. I don't know if anyone is actually using it.
|
PR #41832: Size comparison from 1089161 to d6ea481 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Summary
We are working towards launching a python support module on PyPI to support local testing for developers who do not work day-to-day on the SDK and would prefer to just pip install a package.
This package contains a single wheel that encompases the following individual wheel files from the SDK
matter-jupiter will be added in a subsequent PR.
The three core matter wheel files are currently being compiled by a secondary script. I opted to keep this in place for this PR to avoid complicating changes, but we should be able to remove the duplication in a follow up and compile the -core, -clusters and -repl wheel files through pigweed for simpliciy.
This PR aims just to match the current python environment setup and therefore still requires that the test scripts themselves be provided. This is another follow up, as is integration of the mdns into the testing framework and inclusion of the support files like the certificates.
A CI test will be added to this PR in a subsequent commit.
Follow up summary for this PR:
Follow up summary:
Related issues
Testing
Still in progress, this is just a preview.
Will follow up in this PR before undrafting with a CI action to show at least one dm-related test working
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines