XML Changes for Improved Capabilities in General Diagnostics and Basic Info #41834
+4,000
−1,542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
darwin
controller
app
examples chef
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates XML data models to introduce a new DeviceLoad struct in the General Diagnostics cluster and modifies attributes in the Basic Information cluster. The changes are primarily within .matter and .xml files, which, according to the repository's style guide, are outside the scope of this review. The remaining modifications are in auto-generated files, which consistently reflect the data model updates. Given these constraints, I have no specific feedback. The changes appear correct and consistent with the PR's objectives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is XML (and codegen) updates to add the new struct for DeviceLoad in general diagnostics. It also adds attribute updates in basic information and bridges device basic information.
Testing