Skip to content

Fix missing report generation for PushAV and TLS clusters when Commands change attributes #41837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix missing report generation for PushAV and TLS clusters when Commands change attributes #41837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eaaaf2
[PushAV] Add call to report generation on SetTransportStatus and
pidarped Nov 6, 2025
7539eec
[TLSCert and TLSClient Management] Add attribute change reporting when
pidarped Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/app/clusters/push-av-stream-transport-server/push-av-stream-transport-logic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,9 @@ PushAvStreamTransportServerLogic::HandleModifyPushTransport(CommandHandler & han
if (status == Status::Success)
{
transportConfiguration->SetTransportOptionsPtr(transportOptionsPtr);

MatterReportingAttributeChangeCallback(mEndpointId, PushAvStreamTransport::Id,
PushAvStreamTransport::Attributes::CurrentConnections::Id);
}

handler.AddStatus(commandPath, status);
Expand Down Expand Up @@ -1079,6 +1082,9 @@ PushAvStreamTransportServerLogic::HandleSetTransportStatus(CommandHandler & hand
}
}
}

MatterReportingAttributeChangeCallback(mEndpointId, PushAvStreamTransport::Id,
PushAvStreamTransport::Attributes::CurrentConnections::Id);
}
handler.AddStatus(commandPath, status);

Expand Down
25 changes: 25 additions & 0 deletions src/app/clusters/tls-certificate-management-server/tls-certificate-management-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,11 @@ void TlsCertificateManagementServer::HandleProvisionRootCertificate(HandlerConte
}

VerifyOrDieWithMsg(response.caid <= kMaxRootCertId, NotSpecified, "Spec requires CAID to be < kMaxRootCertId");

ctx.mCommandHandler.AddResponse(ctx.mRequestPath, response);

MatterReportingAttributeChangeCallback(ctx.mRequestPath.mEndpointId, TlsCertificateManagement::Id,
TlsCertificateManagement::Attributes::ProvisionedRootCertificates::Id);
}

void TlsCertificateManagementServer::HandleFindRootCertificate(HandlerContext & ctx, const FindRootCertificate::DecodableType & req)
Expand Down Expand Up @@ -338,6 +342,13 @@ void TlsCertificateManagementServer::HandleRemoveRootCertificate(HandlerContext
ctx.mCommandHandler.AddStatus(ctx.mRequestPath, Status::InvalidInState));

auto result = mDelegate.RemoveRootCert(ctx.mRequestPath.mEndpointId, ctx.mCommandHandler.GetAccessingFabricIndex(), req.caid);

if (result == Status::Success)
{
MatterReportingAttributeChangeCallback(ctx.mRequestPath.mEndpointId, TlsCertificateManagement::Id,
TlsCertificateManagement::Attributes::ProvisionedRootCertificates::Id);
}

ctx.mCommandHandler.AddStatus(ctx.mRequestPath, result);
}

Expand Down Expand Up @@ -412,6 +423,13 @@ void TlsCertificateManagementServer::HandleProvisionClientCertificate(HandlerCon
ctx.mCommandHandler.AddStatus(ctx.mRequestPath, Status::NotFound));

auto status = mDelegate.ProvisionClientCert(ctx.mRequestPath.mEndpointId, fabric, req);

if (status == Status::Success)
{
MatterReportingAttributeChangeCallback(ctx.mRequestPath.mEndpointId, TlsCertificateManagement::Id,
TlsCertificateManagement::Attributes::ProvisionedClientCertificates::Id);
}

ctx.mCommandHandler.AddStatus(ctx.mRequestPath, status);
}

Expand Down Expand Up @@ -498,6 +516,13 @@ void TlsCertificateManagementServer::HandleRemoveClientCertificate(HandlerContex

auto result =
mDelegate.RemoveClientCert(ctx.mRequestPath.mEndpointId, ctx.mCommandHandler.GetAccessingFabricIndex(), req.ccdid);

if (result == Status::Success)
{
MatterReportingAttributeChangeCallback(ctx.mRequestPath.mEndpointId, TlsCertificateManagement::Id,
TlsCertificateManagement::Attributes::ProvisionedClientCertificates::Id);
}

ctx.mCommandHandler.AddStatus(ctx.mRequestPath, result);
}

Expand Down
10 changes: 10 additions & 0 deletions src/app/clusters/tls-client-management-server/tls-client-management-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ void TlsClientManagementServer::HandleProvisionEndpoint(HandlerContext & ctx,
if (status.IsSuccess())
{
ctx.mCommandHandler.AddResponse(ctx.mRequestPath, response);

MatterReportingAttributeChangeCallback(ctx.mRequestPath.mEndpointId, TlsClientManagement::Id,
TlsClientManagement::Attributes::ProvisionedEndpoints::Id);
}
else
{
Expand Down Expand Up @@ -209,6 +212,13 @@ void TlsClientManagementServer::HandleRemoveEndpoint(HandlerContext & ctx, const

auto status = mDelegate.RemoveProvisionedEndpointByID(ctx.mRequestPath.mEndpointId,
ctx.mCommandHandler.GetAccessingFabricIndex(), req.endpointID);

if (status == Status::Success)
{
MatterReportingAttributeChangeCallback(ctx.mRequestPath.mEndpointId, TlsClientManagement::Id,
TlsClientManagement::Attributes::ProvisionedEndpoints::Id);
}

ctx.mCommandHandler.AddStatus(ctx.mRequestPath, status);
}

Expand Down
Loading