Integrate network-manager with openthread-br plus miscellaneous updates #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ksperling-apple
commented
Nov 4, 2025
ksperling-apple
commented
- Enable network-manager integration with openthread-br over ubus
- Update mDNSReponder package to 2881.0.25
- Build system tweaks to capture git metadata into downloaded source archives
- Move CI to OpenWrt 24.10.4
…m the git repository and include it in the download archive for use at build time.
This change integrates the TBRM cluster with openthread-br using ubus.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a range of updates, including the integration of network-manager with openthread-br, an update to the mDNSReponder package, a CI migration to a newer OpenWrt version, and a new build system utility for capturing git metadata. The changes are generally well-structured and align with the stated objectives. I've identified a couple of issues in the new git-with-metadata utility that could lead to build failures or unexpected behavior. My review includes specific suggestions to address these points to ensure the new functionality is robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.