use CLI `output` value as path of `generate` directory (if an `output` value is provided) #1622

keaton22 · 2025-07-16T20:39:14Z

Problem

As far as I can tell, when opening a ZAP project from the CLI, if a value is provided for --output/--out/--o, that value does not get used as the default path for the Generate directory. I believe it should.

Solution

This PR makes the value of --output/--out/--o query-able from the front-end by passing it as a parameter in the uiFunction() in startup.js.

Notes

In Windows, the path value passed to --output/--out/--o must use escaped backslashes (e.g. C:\\Users\\username\\zap-projects)

CLAassistant · 2025-07-16T20:39:21Z

All committers have signed the CLA.

gemini-code-assist

Summary of Changes

Hello @keaton22, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a usability issue where the CLI --output parameter was not being utilized as the default path for the 'Generate' directory within the application's user interface. My changes ensure that this CLI-provided path is properly propagated through the Electron main and UI processes, allowing the frontend to use it as the default, thereby improving the consistency and user experience when interacting with the application via the command line.

Highlights

CLI Output Path Propagation: I've updated the application's startup process to ensure that the --output value provided via the command line interface (CLI) is correctly passed from the main Electron process down to the UI components. This involves modifying several functions in src-electron/main-process/startup.js, src-electron/ui/main-ui.js, src-electron/ui/ui-util.js, and src-electron/ui/window.js to accept and forward this new parameter.
Default Generation Directory in UI: The UI component ZCLToolbar.vue now leverages the propagated --output value. Specifically, the generationDirectory property is initialized with this CLI-provided path. Furthermore, when a new generation directory is reported (e.g., via a file dialog), the UI will now fall back to the CLI --output value if the reported path is null or undefined, ensuring a consistent default.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly implements the feature to use the --output CLI argument as the default generation directory in the UI. The value is plumbed from the main process to the renderer process via a query string parameter, which is a reasonable approach. The changes are consistent across the affected files.

My main feedback is to update the JSDoc comments for the functions whose signatures have been changed to include the new output parameter. This is important for maintaining code clarity and documentation consistency.

gemini-code-assist · 2025-07-16T20:40:35Z

src-electron/ui/ui-util.js

+function enableUi(
+  port,
+  zapFiles,
+  uiMode,
+  standalone,
+  zapFileExtensions,
+  output
+) {


The JSDoc for enableUi is missing documentation for the new output parameter. Please add @param {*} output to the documentation block to keep it up-to-date with the function signature and improve maintainability.

I've updated the commit to fix this

gemini-code-assist · 2025-07-16T20:40:36Z

src-electron/ui/window.js

 * @param {*} port
 */
-export function windowCreateIfNotThere(port) {
+export function windowCreateIfNotThere(port, output) {


The JSDoc for windowCreateIfNotThere should be updated to include the new output parameter. This will help maintain code clarity and ensure the documentation matches the implementation.

I've updated the commit to fix this

gemini-code-assist · 2025-07-16T20:40:36Z

src-electron/ui/window.js

  restPort,
-  zapFileExtensions
+  zapFileExtensions,
+  output


The JSDoc for createQueryString should be updated to include the new output parameter. The existing JSDoc appears to be out of sync with other parameters as well, but at a minimum, the new parameter should be documented.

I've updated the commit to fix this

… provided)

keaton22 · 2025-09-04T16:40:21Z

@paulr34 @tecimovic @brdandu I want to be respectful of your time and availability, but I would be very appreciative if I could get some feedback on this pull request. Thank you!

paulr34 · 2025-09-04T16:45:21Z

@keaton22 the workflow is not running. That needs to pass.

…tory-if-provided

keaton22 · 2025-09-04T16:56:52Z

@keaton22 the workflow is not running. That needs to pass.

Thank you @paulr34! I've merged the latest changes from main into this branch, which I believe triggered the Summary workflow to run. I still see Build ZAP, Prepare Zap and regenerate Zigbee, and Test matter sdk codegen changes workflows as pending (specifically, they're marked as Expected — Waiting for status to be reported). Do you know of any additional actions I should take to facilitate running the remaining workflows, or are those triggered manually / later?

keaton22 requested review from brdandu, paulr34 and tecimovic as code owners July 16, 2025 20:39

gemini-code-assist bot reviewed Jul 16, 2025

View reviewed changes

keaton22 force-pushed the use-output-value-as-path-of-generate-directory-if-provided branch from 4646345 to a6d7bb6 Compare July 16, 2025 20:46

use output value as path of generate directory (if an output is…

263d2ce

… provided)

keaton22 force-pushed the use-output-value-as-path-of-generate-directory-if-provided branch from 96b1592 to 263d2ce Compare July 18, 2025 19:05

paulr34 approved these changes Sep 4, 2025

View reviewed changes

Merge branch 'master' into use-output-value-as-path-of-generate-direc…

6057ce7

…tory-if-provided

use CLI output value as path of generate directory (if an output value is provided) #1622

Are you sure you want to change the base?

use CLI output value as path of generate directory (if an output value is provided) #1622

Uh oh!

Conversation

keaton22 commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Notes

Uh oh!

CLAassistant commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

keaton22 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

keaton22 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

keaton22 Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

keaton22 commented Sep 4, 2025

Uh oh!

paulr34 commented Sep 4, 2025

Uh oh!

keaton22 commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

use CLI `output` value as path of `generate` directory (if an `output` value is provided) #1622

use CLI `output` value as path of `generate` directory (if an `output` value is provided) #1622

keaton22 commented Jul 16, 2025 •

edited

Loading

CLAassistant commented Jul 16, 2025 •

edited

Loading

keaton22 commented Sep 4, 2025 •

edited

Loading