-
Notifications
You must be signed in to change notification settings - Fork 89
update pkg runtime to Node 20 for zap-cli packaging #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dhchandw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the project's build and packaging configuration. It upgrades the target Node.js version and updates a key dependency ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Node.js target for packaging from version 18 to 20 and updates the pkg dependency accordingly. This is a great improvement as Node.js 20 is the current LTS version. The changes are consistently applied across the relevant build scripts and configurations. I have provided one comment to highlight an area where this update could be extended for better consistency. On a general note, for future pull requests, please consider providing a descriptive title and a summary of the changes in the description to help reviewers better understand the context and purpose of the changes.
package.json
Outdated
| "nodejs-file-downloader": "^4.9.3", | ||
| "octokit": "^1.7.2", | ||
| "pkg": "^5.8.1", | ||
| "@yao-pkg/pkg": "^6.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg name changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as discussed this is the most active fork of pkg, the original pkg module has been deprecated and doesn't have support for node20.
ZAPP-1678