Handle matrix.to room alias and room ID links. #531

tyreseluo · 2025-06-28T06:20:29Z

PR content

Add support for clicking matrix.to links in room messages to navigate to rooms and resolve room aliases.
Implement async room alias resolution with proper error handling and user feedback through popup notifications.

Related PR

Properly handle matrix.to links for Rooms #87

1. Add support for clicking matrix.to links in room messages to navigate to rooms and resolve room aliases. 2. Implement async room alias resolution with proper error handling and user feedback through popup notifications.

kevinaboos

Thanks for the PR.

I'm a bit confused about the title of this PR. When you "handle" room aliases and links, what do you mean by "handle"? I would expect the UI to open a new tab (in Desktop mode) and show that room's content if it's joined, or if it hasn't been joined yet, then show a new view with a preview of that room and a prompt asking the user to join it.

And then in Mobile mode, the same thing would happen, but you'd just show the new room in a view that replaces the existing RoomScreen, instead of opening a new tab (since there are no tabs). I was under the impression that we'd need Julian's new stack navigation PR in order to handle this properly, in which we're able to "push" the new room view onto the stack of existing views (such that you can navigate backwards to the rooms you viewed previously). Without that functionality, we can't really offer a good user experience of navigating between multiple rooms.

This PR doesn't really seem to do any of that, so I'm a bit confused about what you intended the scope of this to be.

kevinaboos · 2025-07-01T00:34:20Z

src/home/room_screen.rs

+                        c.rooms().into_iter().find(|room| {
+                            room.canonical_alias().as_ref() == Some(room_alias) ||
+                            room.alt_aliases().contains(room_alias)
+                        })


this is very expensive --- we cannot iterate over all rooms in the client on the main UI thread.

You deleted my comments, but those comments clearly stated what we needed to do. We do need to show a loading screen (like how I use the LoadingPane widget when looking for an old replied-to message) while waiting on a background task to resolve the room alias. This is not optional, and I left the same comment on your previous PR on this topic.

Recall that in general, we want to avoid doing as much work as possible on the main UI thread, and move as many things as possible to a background task/thread.

kevinaboos · 2025-07-01T00:34:41Z

src/home/room_screen.rs

-                        log!("TODO: jump to known room {}", room_id);
+                    if let Some(known_room) = get_client().and_then(|c| c.get_room(room_id)) {
+                        cx.widget_action(uid, &Scope::empty().path, RoomsListAction::Selected(
+                            SelectedRoom::JoinedRoom {


how do you know the room is a Joined room here? what if it's an invite?

kevinaboos · 2025-07-01T00:39:00Z

src/home/room_screen.rs

+                    // Only handle this action if it was requested by this widget
+                    if *requester_uid == room_screen_widget_uid {


while it seems like a good idea to use the RoomScreen widget UID for this, we should use the Room ID instead. The reason for this is because if the user changes from Desktop to Mobile view (or simply closes the RoomScreen tab and opens it in a new tab), then the widget UID will change, so this condition will never occur.

We want any RoomScreen that is showing this room's Room ID to be able to handle this resolved room alias action.

kevinaboos · 2025-07-01T00:39:18Z

src/home/room_screen.rs

@@ -995,6 +996,43 @@ impl Widget for RoomScreen {
                        );
                    }
                }
+
+                // Handle resolved room alias actions - only for requests from this widget
+                if let Some(ResolveRoomAliasAction::Resolved { requester_uid, room_alias: _ , room_id, servers: _ }) = action.downcast_ref() {


you should use a match statement for all ResolveRoomAliasActions, not multiple separate if let blocks.

kevinaboos · 2025-07-01T00:40:16Z

src/home/room_screen.rs

+                        if let Some(known_room) = get_client().and_then(|c| c.get_room(room_id)) {
+                            if known_room.is_space() {
+                                enqueue_popup_notification(PopupItem {
+                                    message: format!("Found space {} but it is a space, not a regular room.", room_id),


This is fine, but the real reason that we can't do anything here is because we don't yet support showing a preview of a Space itself.

Suggested change

message: format!("Found space {} but it is a space, not a regular room.", room_id),

message: String::from("Showing a space's home page is not yet supported."),

kevinaboos · 2025-07-01T00:40:47Z

src/home/room_screen.rs

+                                });
+                            } else {
+                                cx.widget_action(room_screen_widget_uid, &scope.path, RoomsListAction::Selected(
+                                    SelectedRoom::JoinedRoom {


why are you assuming this is a joined room?

kevinaboos · 2025-07-01T00:42:21Z

src/home/room_screen.rs

+                            }
+                        } else {
+                            enqueue_popup_notification(PopupItem {
+                                message: format!("Found room {} but you are not joined to it yet.", room_id),


i dont understand this error condition. Why is it a problem that the room hasn't been joined yet? Can't you request a preview of non-joined rooms?

(Note that my comment that you removed also mentioned this. I believe that Client::get_room_preview() will handle all of the cases here.)

The only conditions we'd want to notify the user of are:

an error if we cannot fetch the room preview

a notice if the room exists but cannot be previewed and must be joined instead

kevinaboos · 2025-07-01T05:05:19Z

src/home/room_screen.rs

+                                auto_dismissal_duration: Some(3.0)
+                            });
+                        } else {
+                            cx.widget_action(uid, &Scope::empty().path, RoomsListAction::Selected(


you're assuming this room has been joined again.

tyreseluo · 2025-07-08T06:02:04Z

Blocked on Makepad PR see: makepad/makepad#766

tyreseluo · 2025-07-16T16:24:42Z

@kevinaboos Need to update latest Makepad version, because Julian's PR about StackNavigation has been merged makepad/makepad#766, need to use something about that PR. Thanks. now i use my local latest makepad repo.

kevinaboos · 2025-07-18T19:01:08Z

@kevinaboos Need to update latest Makepad version, because Julian's PR about StackNavigation has been merged makepad/makepad#766, need to use something about that PR. Thanks. now i use my local latest makepad repo.

Indeed, thanks for mentioning that. We have a PR already in progress that updates to the latest version of Makepad, which is #521. Once that is merged, you can proceed here.

kevinaboos · 2025-07-18T19:01:17Z

Blocked on #521

Handle matrix.to room alias and room ID links.

24d8652

1. Add support for clicking matrix.to links in room messages to navigate to rooms and resolve room aliases. 2. Implement async room alias resolution with proper error handling and user feedback through popup notifications.

tyreseluo force-pushed the feature/handle_matrix_io_links_for_rooms branch from 4675675 to 24d8652 Compare June 28, 2025 06:23

tyreseluo self-assigned this Jun 28, 2025

kevinaboos requested changes Jul 1, 2025

View reviewed changes

kevinaboos added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Jul 1, 2025

tyreseluo added 3 commits July 3, 2025 12:07

Merge branch 'main' into feature/handle_matrix_io_links_for_rooms

5462d28

Merge branch 'main' into feature/handle_matrix_io_links_for_rooms

fb40970

Update handle room matrix.io link

4017881

tyreseluo added the blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature label Jul 8, 2025

tyreseluo removed the blocked-on-makepad Blocked on a Makepad bug or missing Makepad feature label Jul 16, 2025

kevinaboos added the blocked Blocked on another issue or missing feature label Jul 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Handle matrix.to room alias and room ID links. #531

Handle matrix.to room alias and room ID links. #531

Uh oh!

tyreseluo commented Jun 28, 2025

Uh oh!

kevinaboos left a comment

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

kevinaboos Jul 1, 2025

Uh oh!

tyreseluo commented Jul 8, 2025

Uh oh!

tyreseluo commented Jul 16, 2025 •

edited

Loading

Uh oh!

kevinaboos commented Jul 18, 2025

Uh oh!

kevinaboos commented Jul 18, 2025

Uh oh!

Uh oh!

		// Only handle this action if it was requested by this widget
		if *requester_uid == room_screen_widget_uid {

	message: format!("Found space {} but it is a space, not a regular room.", room_id),
	message: String::from("Showing a space's home page is not yet supported."),

Handle matrix.to room alias and room ID links. #531

Are you sure you want to change the base?

Handle matrix.to room alias and room ID links. #531

Uh oh!

Conversation

tyreseluo commented Jun 28, 2025

PR content

Related PR

Uh oh!

kevinaboos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tyreseluo commented Jul 8, 2025

Uh oh!

tyreseluo commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevinaboos commented Jul 18, 2025

Uh oh!

kevinaboos commented Jul 18, 2025

Uh oh!

Uh oh!

tyreseluo commented Jul 16, 2025 •

edited

Loading