Skip to content

feat: Add arm64 windows support for docker #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: Add arm64 windows support for docker #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3428ace
feat: Add arm64 windows support for docker
jkroepke Nov 14, 2024
6efefcc
Merge branch 'master' into arm64
jkroepke May 24, 2025
8b9107c
container: fix collector
jkroepke May 24, 2025
2105728
chore: fix test
jkroepke May 31, 2025
3be0c6b
chore: fix test
jkroepke May 31, 2025
06b2e31
Merge branch 'master' into arm64
jkroepke Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,5 +240,4 @@ jobs:
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
platforms: windows/amd64
annotations: ${{ steps.meta.outputs.labels }}
platforms: windows/amd64,windows/arm64
8 changes: 6 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@
# This image MUST be built with docker buildx build (buildx) command on a Linux system.
# Ref: https://github.com/microsoft/windows-host-process-containers-base-image

ARG BUILDARCH
ARG TARGETARCH

ARG BASE="mcr.microsoft.com/oss/kubernetes/windows-host-process-containers-base-image:v1.0.0"
FROM $BASE

COPY windows_exporter*-amd64.exe /windows_exporter.exe
FROM --platform=windows/$BUILDARCH $BASE

COPY windows_exporter*-${TARGETARCH}.exe /windows_exporter.exe

Check warning on line 16 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build docker images

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$TARGETARCH'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
ENTRYPOINT ["windows_exporter.exe"]