feat: support arbitrary query params in request #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
Adds 'WithCustomOption()' func which allows setting arbitrary key/value pairs to the URL query parameters of the request. The primary use case for this is to work with https://github.com/prometheus-community/prom-label-proxy. Signed-off-by: Alec Merdler <[email protected]>
alecmerdler
force-pushed
the
support-arbitrary-query-params
branch
from
7a81563 to
d46b13d
Compare
|
This is a naive approach, I will be happy to update the pull request with any feedback. But as it stands today, the official Prometheus client cannot be used with |
|
@alecmerdler Let's open an issue and discuss this further before jumping into any conclusions. I would love to learn more about your use cases, especially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
WithCustomOption()func which allowssetting arbitrary key/value pairs to the URL
query parameters of the request.
The primary use case for this is to work with
https://github.com/prometheus-community/prom-label-proxy.