SRU2025 #162
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,9 +5,9 @@ buildscript { | |
| } | ||
| dependencies { | ||
| classpath 'ru.vyarus:gradle-quality-plugin:5.0.0' | ||
| classpath 'pl.allegro.tech.build:axion-release-plugin:1.18.18' | ||
| classpath 'io.github.gradle-nexus:publish-plugin:2.0.0' | ||
| classpath 'com.diffplug.spotless:spotless-plugin-gradle:7.0.3' | ||
| } | ||
| } | ||
| apply plugin: 'pl.allegro.tech.build.axion-release' | ||
|
|
@@ -23,8 +23,12 @@ archivesBaseName = 'pw-iso20022' | |
| group 'com.prowidesoftware' | ||
|
|
||
| project.ext { | ||
| SRU = 'SRU2025' | ||
| prowideCoreVersion = 'SRU2025-10.3.0-SNAPSHOT' | ||
| commonsLangVersion = '3.17.0' | ||
| gsonVersion = '2.13.1' | ||
| jaxbVersion = '4.0.5' | ||
| jakartaPersistenceVersion = '3.1.0' // jakarta 3.1 is Jakarta EE 10, jakarta 3.2 would imply migration to Jakarta EE 11 | ||
| } | ||
|
|
||
| scmVersion { | ||
|
|
@@ -34,6 +38,7 @@ scmVersion { | |
| } | ||
| } | ||
| project.version = "${SRU}-${scmVersion.version}" | ||
| project.version = "SRU2025-10.3.0-SNAPSHOT" | ||
|
|
||
| allprojects { | ||
|
|
||
|
|
@@ -101,9 +106,9 @@ subprojects { | |
| version = rootProject.version | ||
|
|
||
| dependencies { | ||
| implementation "org.apache.commons:commons-lang3:${commonsLangVersion}" | ||
| implementation "com.google.code.gson:gson:${gsonVersion}" | ||
| implementation "com.sun.xml.bind:jaxb-impl:${jaxbVersion}" | ||
| // bind-api is included transitively by jaxb-impl | ||
| // implementation 'jakarta.xml.bind:jakarta.xml.bind-api:4.0.2' | ||
| } | ||
|
|
@@ -127,14 +132,14 @@ configure(subprojects.findAll {it.name.endsWith('-mx')}) { | |
| api project(':iso20022-core') | ||
| implementation project(specificTypesProject) | ||
|
|
||
| implementation "org.apache.commons:commons-lang3:${commonsLangVersion}" | ||
| implementation "com.google.code.gson:gson:${gsonVersion}" | ||
|
|
||
| implementation "com.sun.xml.bind:jaxb-impl:${jaxbVersion}" | ||
| // bind-api is included transitively by jaxb-impl | ||
| // implementation 'jakarta.xml.bind:jakarta.xml.bind-api:4.0.2' | ||
|
|
||
| compileOnly "jakarta.persistence:jakarta.persistence-api:${jakartaPersistenceVersion}" | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -150,13 +155,13 @@ project(':iso20022-core') { | |
| // included build | ||
| api "com.prowidesoftware:pw-swift-core:${prowideCoreVersion}" | ||
|
|
||
| implementation "org.apache.commons:commons-lang3:${commonsLangVersion}" | ||
| implementation "com.google.code.gson:gson:${gsonVersion}" | ||
|
|
||
| compileOnly "jakarta.persistence:jakarta.persistence-api:${jakartaPersistenceVersion}" | ||
| compileOnly 'jakarta.validation:jakarta.validation-api:3.1.0' | ||
|
|
||
| testImplementation "jakarta.persistence:jakarta.persistence-api:${jakartaPersistenceVersion}" | ||
| testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4' | ||
| testImplementation 'com.google.guava:guava:33.4.0-jre' | ||
| testImplementation 'org.assertj:assertj-core:3.27.2' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-bin.zip | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,9 +15,6 @@ | |
| */ | ||
| package com.prowidesoftware.swift.model; | ||
|
|
||
| /** | ||
| * SWIFT business process classification for MX messages. | ||
| * | ||
|
|
@@ -57,14 +54,6 @@ public enum MxBusinessProcess { | |
| setr("Securities Trade"), | ||
| supl("Supplementary Data"), | ||
| trck("Payments Tracker"), | ||
| tsin("Trade Services Initiation"), | ||
| tsmt("Trade Services Management"), | ||
| tsrv("Trade Services"), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ | |
| import com.google.gson.Gson; | ||
| import com.google.gson.GsonBuilder; | ||
| import com.prowidesoftware.JsonSerializable; | ||
| import com.prowidesoftware.deprecation.ProwideDeprecated; | ||
| import com.prowidesoftware.deprecation.TargetYear; | ||
| import com.prowidesoftware.swift.model.AbstractMessage; | ||
|
|
@@ -27,11 +26,9 @@ | |
| import com.prowidesoftware.swift.model.mt.AbstractMT; | ||
| import com.prowidesoftware.swift.model.mx.adapters.*; | ||
| import com.prowidesoftware.swift.model.mx.adapters.v9.V9DateTimeJsonAdapter; | ||
| import jakarta.xml.bind.JAXBContext; | ||
| import jakarta.xml.bind.annotation.XmlTransient; | ||
| import java.io.StringReader; | ||
| import java.time.*; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
@@ -73,7 +70,7 @@ public abstract class AbstractMX extends AbstractMessage implements JsonSerializ | |
| * @deprecated the default root element for the custom envelope is now defined in {@link EnvelopeType#CUSTOM} | ||
| */ | ||
| @Deprecated | ||
| @ProwideDeprecated(phase3 = TargetYear.SRU2026) | ||
| public static String DEFAULT_ROOT_ELEMENT = "RequestPayload"; | ||
|
|
||
| /** | ||
|
|
@@ -129,17 +126,6 @@ public static AbstractMX parse(final String xml, MxId id) { | |
| return MxReadImpl.parse(xml, id, new MxReadParams()); | ||
| } | ||
|
|
||
| /** | ||
| * Parses the XML Element into a specific MX object. | ||
| * The Mx to create is detected from the namespace. | ||
|
|
@@ -412,21 +398,6 @@ public String document() { | |
| return document(params); | ||
| } | ||
|
|
||
| /** | ||
| * Convenience method to get this message XML as javax.xml.transform.Source. | ||
| * | ||
|
|
@@ -460,34 +431,6 @@ public String message() { | |
| return message(new MxWriteConfiguration()); | ||
| } | ||
|
|
||
| /** | ||
| * @return the business header or null if not set | ||
| * @since 9.0.1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,11 +15,7 @@ | |
| */ | ||
| package com.prowidesoftware.swift.model.mx; | ||
|
|
||
| import java.time.OffsetDateTime; | ||
| import org.w3c.dom.Element; | ||
|
|
||
| /** | ||
|
|
@@ -106,13 +102,6 @@ public interface AppHdr { | |
| */ | ||
| void setCreationDate(boolean overwrite); | ||
|
|
||
| /** | ||
| * Get this header as an XML string. | ||
| * <p>The implementation uses {@link #xml(MxWriteParams)} with no prefix and no XML declaration. | ||
|
|
@@ -123,35 +112,14 @@ default String xml() { | |
| return xml(new MxWriteParams()); | ||
| } | ||
|
|
||
| /** | ||
| * Get this header as an XML string. | ||
| * | ||
| * @param params not null marshalling parameters | ||
| * @return header serialized into XML string or null in case of unexpected error | ||
| * @since 9.2.6 | ||
| */ | ||
| String xml(MxWriteParams params); | ||
|
|
||
| /** | ||
| * Gets the header as an Element object. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,8 +58,7 @@ public static Optional<AppHdr> parse(final String xml, MxReadParams params) { | |
|
|
||
| Optional<String> namespace = NamespaceReader.findAppHdrNamespace(xml); | ||
|
|
||
| boolean headerIsPresent = namespace.isPresent() || MxParseUtils.elementExists(xml, AppHdr.HEADER_LOCALNAME); | ||
|
|
||
| if (headerIsPresent) { | ||
| AppHdr parsedHeader = parseHeaderFromSAXSource(xml, namespace.orElse(null), params); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,9 +16,6 @@ | |
| package com.prowidesoftware.swift.model.mx; | ||
|
|
||
| import com.prowidesoftware.ProwideException; | ||
| import com.prowidesoftware.swift.model.mx.adapters.IsoDateTimeAdapter; | ||
| import com.prowidesoftware.swift.model.mx.adapters.ZuluOffsetDateTimeAdapter; | ||
| import com.prowidesoftware.swift.model.mx.dic.BusinessApplicationHeaderV01Impl; | ||
|
|
@@ -188,36 +185,6 @@ public void setCreationDate(boolean overwrite) { | |
| } | ||
| } | ||
|
|
||
| @Override | ||
| public String xml(MxWriteParams params) { | ||
| try { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Update deprecation documentation URL
The URL for the deprecation documentation still references SRU2024, but this PR is for SRU2025.
Check if an updated URL for SRU2025 deprecation documentation exists, and update the reference accordingly if available.
🌐 Web query:
💡 Result:
Based on the search results, there is no explicit mention of an SRU2025 deprecation documentation page for Prowide. The search results contain information about Prowide's deprecation policy in general and references to documentation pages for previous SRU (SWIFT Release Update) versions such as SRU2024, SRU2023, and earlier releases.
The deprecation policy is documented at "https://dev.prowidesoftware.com/latest/getting-started/deprecation/" which explains Prowide's approach to API deprecation in phases[6]. This general policy document dates back to April 2016 and outlines a four-phase deprecation process that spans at least 4 years from the initial deprecation mark to deletion.
When discussing specific SRU versions, the search results show that Prowide typically includes a "yearly revision of deprecation phase" in their release notes, with references to the deprecation policy page. For example, in the changelog for SRU2024 (version 10.2.0), they mention "Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/)"[7][9].
While there is mention of SRU2025 in the context of hybrid addresses support (starting by the end of November 2025)[4], there is no specific mention of an SRU2025 deprecation documentation page in the provided search results.
Citations:
Update deprecation documentation URL to use the generic “latest” page
Please update the SRU2024‐specific link in CHANGELOG.md to point at the general deprecation policy, as there is no SRU2025‐specific page:
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
5-5: Bare URL used
null
(MD034, no-bare-urls)
🤖 Prompt for AI Agents (early access)