-
Notifications
You must be signed in to change notification settings - Fork 74
chore: update V8 to 13.8.258.26 #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonm1
wants to merge
11
commits into
proxy-wasm:main
Choose a base branch
from
leonm1:chore/update-v8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Michael Warres <[email protected]>
PiotrSikora
reviewed
Jul 17, 2025
3e9f030
to
1caa20f
Compare
martijneken
approved these changes
Jul 18, 2025
aabaa9e
to
0304328
Compare
b213f3d
to
c9c9eb2
Compare
mpwarres
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod fixing the macos build errors. I am wondering if it might be possible to defer that branch of yak-shaving by not updating the macos runner in this PR, unless it is required for some reason.
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
This test fails with the new V8 version Signed-off-by: Matt Leon <[email protected]>
BSD sed requires an extension to create a backup file when used with in-place editing. Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Fixes macos build Signed-off-by: Matt Leon <[email protected]>
Signed-off-by: Matt Leon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #441.