Skip to content

chore: update V8 to 13.8.258.26 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

leonm1
Copy link
Contributor

@leonm1 leonm1 commented Jul 17, 2025

  • Update v8.patch
  • Remove v8_include.patch which is no longer needed
  • Remove dependency on chromium_base_trace_event_common
  • Use vendored LLVM-19
  • Update runners

This PR is stacked on top of #441.

@leonm1 leonm1 changed the base branch from mpwarres-use-cpp-20-2 to main July 17, 2025 02:47
@leonm1 leonm1 force-pushed the chore/update-v8 branch from ebfe552 to d2b91ac Compare July 17, 2025 03:05
mpwarres added 2 commits July 17, 2025 09:35
Signed-off-by: Michael Warres <[email protected]>
Signed-off-by: Michael Warres <[email protected]>
@leonm1 leonm1 force-pushed the chore/update-v8 branch from b69ca9b to 5f35a6d Compare July 17, 2025 21:13
@leonm1 leonm1 force-pushed the chore/update-v8 branch 2 times, most recently from 3e9f030 to 1caa20f Compare July 18, 2025 13:43
@leonm1 leonm1 force-pushed the chore/update-v8 branch 2 times, most recently from aabaa9e to 0304328 Compare July 18, 2025 14:21
@leonm1 leonm1 force-pushed the chore/update-v8 branch 7 times, most recently from b213f3d to c9c9eb2 Compare July 18, 2025 18:45
Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod fixing the macos build errors. I am wondering if it might be possible to defer that branch of yak-shaving by not updating the macos runner in this PR, unless it is required for some reason.

@leonm1 leonm1 force-pushed the chore/update-v8 branch from 8e56d76 to 9c8fcba Compare July 21, 2025 16:10
leonm1 added 6 commits July 21, 2025 16:18
This test fails with the new V8 version

Signed-off-by: Matt Leon <[email protected]>
BSD sed requires an extension to create a backup file when used with in-place editing.

Signed-off-by: Matt Leon <[email protected]>
Fixes macos build

Signed-off-by: Matt Leon <[email protected]>
@leonm1 leonm1 force-pushed the chore/update-v8 branch from 9c8fcba to 8f1af46 Compare July 21, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants