fix: package compatibility with web build #138
+567
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 13, 2025 20:01
added web compatibility test
parfeon
approved these changes
Aug 13, 2025
| 'membersMetadata': membersMetadata, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we have @override here?
There was a problem hiding this comment.
Since toJson() is not universal and it’s a per-class convention it's not an overridden method.
Also, boolean without assigned in all parameters will be printed null,
and while preparing a url, if those values optional then they are omitted.
added 2 commits
August 13, 2025 21:28
keeping default logger enabled when custom logger provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: compatibility issue with web build
Fixes package compatibility issues with web builds.
refactor: allow custom logger based on ILogger.
Allow global custom logger to be ILogger based.
refactor: upgrade dependencies.
upgrade outdated dependencies.