-
-
Notifications
You must be signed in to change notification settings - Fork 156
Update appimagetool link in ./scripts/fix-linux-appimage.sh #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was going to ask for elaboration on why this change was needed, but I see now that the old tool has had its last release renamed to “obsolete”:
Fair enough! |
A big Electron builder issue that I can't fix, but will help help help you get around in your project is using the deprecated appimagetool instead of appimagetool with type2 support, which will allow you to run appimage without installing additional libraries in distributions like fedora and ubuntu. |
So is the deal that the current AppImage that we distribute won't work on any distro that doesn't ship |
Ubuntu since 22.04, Fedora since 41 |
Luckily, my Ubuntu VM is 22.04.5, so I'll give this a test tomorrow. |
Tried it out quickly… it's true that I needed to do This could just as easily be about some difficulties with running a build process on a local machine instead of in CI, but I'm on an Apple Silicon machine and we don't build ARM64 binaries on PRs. So I'll either have to produce a one-off PR AppImage from our CI somehow, or an X86_64 Linux user can verify. |
Bumping this. @Drsheppard01, I appreciate the contribution, but I can't verify that it still produces a working |
For some reason I switched to Windows and my laptop is running Alpine (Pulsar depends on Electron and to build AppImage for Alpine you need to use patched Electron from this distribution first) and unfortunately I can't test it anymore. I can assure you that it is definitely not harmful |
Yeah, harmful isn't my concern; just want to make sure it produces an AppImage that works. If a Linux x86 user out there could try it out, I'd be grateful. |
Okay, sorry for the long delay in testing... This topic came up again and I spun up an x86_64 Ubuntu 24.04.2 live USB environment... I tested the Appimage from the latest official Pulsar Regular release (https://github.com/pulsar-edit/pulsar/releases/download/v1.128.0/Linux.Pulsar-1.128.0.AppImage) and the AppImage built in a one-off CI run with this commit merged on top of the latest Can confirm this PR's change appears to get rid of the (Presumably because of the newer edition of upstream tooling statically linking libfuse now.)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this based on testing in an Ubuntu 24.04.2 live USB environment, see comment above.
Thank you for investigating this for us and posting this PR! Thanks very much for the contribution!
update appimagetool link, which works without fuse2 lib