Skip to content

add base and refactored examples #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

add base and refactored examples #42

merged 2 commits into from
Sep 4, 2025

Conversation

lichtie
Copy link
Collaborator

@lichtie lichtie commented Sep 2, 2025

No description provided.

@lichtie lichtie self-assigned this Sep 2, 2025
@nelsonfigueroa
Copy link

I see that in the READMEs you have npm install to install dependencies. In my opinion I think it's best to use pulumi install. It handles all the dependency stuff for you regardless of the language.

(Also, I just took a quick look but have not tested out the examples myself.)

nelsonfigueroa
nelsonfigueroa approved these changes Sep 4, 2025
View reviewed changes
Copy link

@nelsonfigueroa nelsonfigueroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichtie lichtie merged commit 50b46cb into main Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nelsonfigueroa nelsonfigueroa nelsonfigueroa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lichtie lichtie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lichtie @nelsonfigueroa