Skip to content

(MODULES-11567): Enhance validation methods to resolve deferred values for validation in sqlserver_instance type #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

span786
Copy link
Contributor

@span786 span786 commented Jun 3, 2025

Summary

Improve validation logic in the sqlserver_instance type to handle deferred values

In the current implementation, when the preprocess_deferred flag is set to true, Puppet resolves deferred values before validation, allowing sqlserver_instance to validate parameters successfully.

However, when preprocess_deferred is false, deferred values remain unresolved at the time of validation, causing it to fail. To address this issue, we’ve updated the validation logic to explicitly resolve deferred values during validation, ensuring the module functions correctly regardless of the preprocess_deferred setting.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@span786 span786 requested a review from a team as a code owner June 3, 2025 12:09
@span786 span786 force-pushed the MODULES-11567-puppetlabs-sqlserver-module-not-compatible-with-puppet-8-changes-to-preprocess-deferred branch 6 times, most recently from 3508d6b to 04f0be4 Compare June 4, 2025 10:23
@span786 span786 marked this pull request as draft June 4, 2025 10:25
@span786 span786 force-pushed the MODULES-11567-puppetlabs-sqlserver-module-not-compatible-with-puppet-8-changes-to-preprocess-deferred branch 12 times, most recently from 7a429d9 to c07cdab Compare June 12, 2025 09:53
@span786
Copy link
Contributor Author

span786 commented Jun 17, 2025

The VMs provisioned here are accessible for only 2 hours, after which connection attempts time out. As a result, the CI tests are timing out when running the full acceptance test suite. Therefore, I’m attaching the spec log for the sqlserver_instance_spec.rb file.
34.19.104.245_spec_sqlserver_instance_report.log

@span786 span786 marked this pull request as ready for review June 17, 2025 06:18
@span786 span786 force-pushed the MODULES-11567-puppetlabs-sqlserver-module-not-compatible-with-puppet-8-changes-to-preprocess-deferred branch 2 times, most recently from a443c02 to 64c803b Compare June 17, 2025 06:37
@span786 span786 marked this pull request as draft June 18, 2025 05:39
@span786 span786 marked this pull request as ready for review June 18, 2025 05:39
@span786 span786 force-pushed the MODULES-11567-puppetlabs-sqlserver-module-not-compatible-with-puppet-8-changes-to-preprocess-deferred branch from 64c803b to c8d9476 Compare June 18, 2025 11:44
@span786 span786 merged commit a90cc7f into main Jun 20, 2025
5 of 11 checks passed
@span786 span786 deleted the MODULES-11567-puppetlabs-sqlserver-module-not-compatible-with-puppet-8-changes-to-preprocess-deferred branch June 20, 2025 08:44
@span786 span786 added the bugfix label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants