Correct cloud_cover_to_transmittance_linear documentation #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
reviewed
Jan 7, 2022
There was a problem hiding this comment.
Thanks @JoLo90! The coverage and pytest failures can be ignored here. One suggestion below, otherwise LGTM
Co-authored-by: Cliff Hansen <[email protected]>
cwhanse
approved these changes
Jan 7, 2022
|
@pvlib/pvlib-maintainer I will merge tomorrow unless additional comments are made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the documentation of the cloud_cover_to_transmittance_linear function. The current return is documented as the ghi instead of the transmittance. The information "percentage" has been added to the cloud cover and "ratio" to the transmittance.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).