Skip to content

Correct "Wind Speed" to "Wind Speed Units" in PSM3 #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Jan 11, 2022

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

There has been a typo in the metadata section of NSRDB PSM3 retrievals (see photo below). Specifically, the column with the wind speed units was called "Wind Speed" but should have been called "Wind Speed Units" to match the other units columns. Paul Edwards (@PjEdwards) from NREL will implement a fix of this today, which will fail the PSM3 tests.

image

@AdamRJensen AdamRJensen changed the title Correct "Wind Speed" to "Wind Speed Units" Correct "Wind Speed" to "Wind Speed Units" in PSM3 Jan 11, 2022
@kandersolar kandersolar added this to the 0.9.1 milestone Jan 11, 2022
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdamRJensen

@kandersolar kandersolar merged commit 12d8295 into pvlib:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants