Don't add duplicate patients #2289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pybind#1251 (patient vector grows without bounds) for the 2.2.2 branch by checking that the vector doesn't already have the given patient. This is a little less elegant than the same fix for `master` in pybind#1253 (which changes the patients `vector` to an `unordered_set`), but that requires an internals layout change, which this approach avoids.
- Checks `not m.has_patients()` after nurse is gc'd - Uses Python implementation of `refcount`
YannickJadoul
approved these changes
Jul 10, 2020
| instance->has_patients = true; | ||
| for (auto &p : current_patients) |
There was a problem hiding this comment.
This could be if (std::find(current_patients.begin(), current_patients.end(), patient) != current_patients.end()), I suppose. Normally that would be cleaner, but now it's actually lengthier. So probably not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1251
Either an alternative or precursor for #1253 - this does not create any ABI issues.
This is the forward-port of 56c1edb from v2.2.2, as mentioned here:
#1251 (comment)
Filed per @YannickJadoul's request:
#1251 (comment)