-
-
Notifications
You must be signed in to change notification settings - Fork 502
Pipeline Job Get SCM Element Bug Fix #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Pipeline Job Get SCM Element Bug Fix #892
Conversation
jenkinsapi/job.py
Outdated
@@ -539,6 +539,13 @@ def get_scm_type(self): | |||
if scm_element: | |||
# multibranch pipeline. | |||
self._scm_prefix = multibranch_scm_prefix | |||
if not scm_element: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we change this to be an else for line 539?
Would you add test coverage for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clintonsteiner, I have updated the alternate scm_element
fetch mechanism. Please check. As per the test coverage, I have added the test case for the change, but it seems like the Jenkins instance used in the tests does not have the Pipeline suite. Please advise on how to proceed.
Single test failures |
any movement on this? this bug is blocking me right now |
@mwPandoraid I am not completely familiar with these tests, and I don't have much time right so it is going to be a while before I can get all the tests to pass. Might I interest you in a workaround for the moment? |
I need to change the SCM branch using a script, pretty sure I can do that by editing the branch config XML directly so if this won't be fixed too soon I'll probably just do that |
Fixes #891