Allow proper type on AnthropicProvider when using Bedrock
#2490
Conversation
PR Change SummaryUpgraded AnthropicProvider and AnthropicModel to support both AsyncAnthropic and AsyncAnthropicBedrock.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
| aws_secret_key: str | None = None, | ||
| aws_access_key: str | None = None, | ||
| aws_region: str | None = None, | ||
| aws_profile: str | None = None, | ||
| aws_session_token: str | None = None, |
There was a problem hiding this comment.
I would prefer to not complicate things here.
The user can just pass the client when using Bedrock.
| except ImportError as _import_error: # pragma: no cover | ||
| raise ImportError( | ||
| 'Please install the `anthropic` package to use the Anthropic provider, ' | ||
| 'you can use the `anthropic` optional group — `pip install "pydantic-ai-slim[anthropic]"`' | ||
| ) from _import_error | ||
|
|
||
| from typing_extensions import TypeAlias |
There was a problem hiding this comment.
Please move this import up (before the try..except).
|
|
||
| class AnthropicProvider(Provider[AsyncAnthropic]): | ||
| ASYNC_ANTHROPIC_CLIENT: TypeAlias = Union[AsyncAnthropic, AsyncAnthropicBedrock] |
There was a problem hiding this comment.
Is it really union what we want?
| ASYNC_ANTHROPIC_CLIENT: TypeAlias = Union[AsyncAnthropic, AsyncAnthropicBedrock] | |
| AsyncAnthropicClient = TypeVar("AsyncAnthropicClient", AsyncAnthropic, AsyncAnthropicBedrock) |
Does this work?
There was a problem hiding this comment.
Don't use full uppercase for type aliases, that's for constants. 🙏
There was a problem hiding this comment.
microsoft/pyright#10777
I started with TypeVar but typecheckers don't allow this
Kludex
changed the title
AnthropicProvider when using Bedrock
| @@ -153,7 +154,7 @@ def __init__( | |||
| model_name: The name of the Anthropic model to use. List of model names available | |||
| [here](https://docs.anthropic.com/en/docs/about-claude/models). | |||
| provider: The provider to use for the Anthropic API. Can be either the string 'anthropic' or an | |||
| instance of `Provider[AsyncAnthropic]`. If not provided, the other parameters will be used. | |||
| instance of `Provider[ASYNC_ANTHROPIC_CLIENT]`. If not provided, the other parameters will be used. | |||
There was a problem hiding this comment.
| instance of `Provider[ASYNC_ANTHROPIC_CLIENT]`. If not provided, the other parameters will be used. | |
| instance of `Provider[AsyncAnthropicClient]`. If not provided, the other parameters will be used. |
| aws_secret_key: AWS secret access key for Bedrock authentication. | ||
| aws_access_key: AWS access key ID for Bedrock authentication. | ||
| aws_region: AWS region for Bedrock service. | ||
| aws_profile: AWS profile name for Bedrock authentication. | ||
| aws_session_token: AWS session token for temporary credentials. |
There was a problem hiding this comment.
| aws_secret_key: AWS secret access key for Bedrock authentication. | |
| aws_access_key: AWS access key ID for Bedrock authentication. | |
| aws_region: AWS region for Bedrock service. | |
| aws_profile: AWS profile name for Bedrock authentication. | |
| aws_session_token: AWS session token for temporary credentials. |
| @@ -35,7 +34,6 @@ | |||
|
|
|||
| test_infer_provider_params = [ | |||
| ('anthropic', AnthropicProvider, 'ANTHROPIC_API_KEY'), | |||
| ('cohere', CohereProvider, 'CO_API_KEY'), | |||
Resolves:
#2215
Summary:
Upgrades AnthropicProvider and AnthropicModel to support both AsyncAnthropic and AsyncAnthropicBedrock.