fix: replace logfire-api with logfire dependency in pydantic-evals #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the MagicMock issue when logfire is not installed by ensuring logfire is always available. Previously, logfire-api provided only the interface while actual span duration calculations require the full logfire package. Fixes #2209 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Marcelo Trylesinski <[email protected]>
Docs Preview
|
DouweM
approved these changes
Aug 15, 2025
|
Adding I need to change the code to use logfire instead of opentelemetry-api, and update the documentation. |
|
Let's add if another problem happens in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the MagicMock issue when logfire is not installed by ensuring logfire is always available. Previously, logfire-api provided only the interface while actual span duration calculations require the full logfire package.
Fixes #2209
Generated with Claude Code