Base header

[oddbookworm]

Another precursor PR to #3477
The reason I want to remove so much static linkage is because you can't test functions that aren't visible to you (not even worth putting those declarations in the header, since anyone that includes the header would need to provide their own implementation to call them).

[gresm]

You could also do in base_test.c:

#include "base.c"

[...]

But that'll make building tests messy...

[oddbookworm]

You could also do in base_test.c:

#include "base.c"

Absolutely not

That begs for linker problems that would be a pain to solve, and ultimately, having a header with all the declarations is just cleaner IMO. Including a source file is just plain nasty

[pmp-p]

there are problems that could be solved i thing by simply merging static and base ( ie when wasm loading pygame_base static could be set to pygame.base by pygame/__init__.py

[pmp-p]

pgExc_SDLError is not defined anymore but it must be a global in the first C module loaded (afaik pygame.base but pygame_static in wasm).

[pmp-p]

same as pgExc_SDLError, this must be in toplevel C module.

[ankith26]

Shouldn't this be global only in the wasm codepath? The same symbol gets reused in the base init function. Alternatively, removing the declaration there could also work.

[pmp-p]

pgExc_SDLError is used everywhere, imho it should not be defined in base init but globally- wasm or not - since it goes out of scope while being exported in c-api pointers

pygame-ce/src_c/base.c

Line 2412 in 7896a55

c_api[0] = pgExc_SDLError;

[pmp-p]

last commit won't do it : wasm at runtime says that pgExc_SDLError needs to be globally exported for dynamic loading.