Refactor rect properties #3492
Open
Refactor rect properties #3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldalma999
reviewed
Oct 16, 2025
Comment on lines
+2455
to
+2460
| RECT_ATTRIBUTE(topright, | ||
| TupleFromTwoPrimitives(self->r.x + self->r.w, self->r.y), | ||
| PrimitiveType val1; | ||
| PrimitiveType val2, twoPrimitivesFromObj(value, &val1, &val2), | ||
| self->r.x = val1 - self->r.w; | ||
| self->r.y = val2;) |
There was a problem hiding this comment.
Not sure how much the formatter allows it, but it was not clear to me that val1 and val2 are in the same argument, or what each argument does. Maybe adding comments might help?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of code used for different rect attributes is repeated. So this PR moves it to macro, and for each attribute only defines unique parts