Added set_led method for Joystick and Controller objects #3507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddbookworm
added
New API
|
Simple test script: import pygame.joystick
pygame.joystick.init()
joy = pygame.joystick.Joystick(0)
joy.set_led(pygame.Color(255, 0, 0)) |
trim.CE315EE5-953B-48EA-A006-A9C5B8149BAE.MOV |
|
I don't currently have a functional SDL3 setup, is someone else able to test it? |
ankith26
reviewed
Jun 17, 2025
|
Tested on SDL3, and after fixing different errors (none of them related to your PR), I can confirm it works, so 👍 on that. However, I agree with Ankith comments on what should be fixed |
MightyJosip
requested changes
Jun 17, 2025
….set_led, and use pg_RGBAFromObjEx instead of pg_RGBAFromObj
…into SDL_JoystickSetLED
ankith26
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
LGTM, thanks for the PR 🎉
I do not have the hardware to test this, but I request @zoldalma999 s review on this as our controller/joystick expert.
MightyJosip
approved these changes
Jun 18, 2025
MightyJosip
changed the title
zoldalma999
approved these changes
Jun 25, 2025
|
@zoldalma999 fixed your nitpick (it was a valid nitpick that I overlooked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3506