Fix editable installation from relative paths on Windows #6416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewartmiles
force-pushed
the
fix_relative_editable_install_win
branch
2 times, most recently
from
cba3996 to
fd75794
Compare
|
Oh things still break when locking as the Windows style path is written to |
stewartmiles
force-pushed
the
fix_relative_editable_install_win
branch
from
fd75794 to
f4b93ba
Compare
I had to fiddle with a few more code paths to get this to work when locking after installing a package from the parent directory of the configured pipenv venv directory. |
stewartmiles
force-pushed
the
fix_relative_editable_install_win
branch
from
f4b93ba to
5c217b9
Compare
When running `pipenv install -e .\..\mypackage` the pip requirement line `-e .\..\mypackage` is written to a temporary requirements file which is passed to pip to install the package. pip fails to install the package from the requirements file as it incorrectly interprets the relative path, treating the slashes as escapes. To work around this issue replace all back slashes (windows directory separators) with forward slashes (POSIX directory separators) in pip requirements for editable package installs.
stewartmiles
force-pushed
the
fix_relative_editable_install_win
branch
from
5c217b9 to
aef9e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
pipenv install -e .\..\mypackagethe pip requirement line-e .\..\mypackageis written to a temporary requirements file which is passed to pip to install the package. pip fails to install the package from the requirements file as it incorrectly interprets the relative path, treating the slashes as escapes. To work around this issue replace all back slashes (windows directory separators) with forward slashes (POSIX directory separators) in pip lines for editable package installs.Thank you for contributing to Pipenv!
The issue
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.
If your pull request makes a significant change to Pipenv, such as the user interface or intended functionality, please open a discussion or issue report first.
The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.