Skip to content

Make node ID modification more stable. #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Draft

Make node ID modification more stable. #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd85718
Make node ID modification more stable.
criemen Aug 21, 2024
6b7156a
Add changelog.
criemen Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/1118.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Loadgroup: Always apply the node ID transformation, even if test collection is run on the controller node.
3 changes: 1 addition & 2 deletions src/xdist/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def pytest_collection_modifyitems(
items: list[pytest.Item],
) -> None:
# add the group name to nodeid as suffix if --dist=loadgroup
if config.getvalue("loadgroup"):
if config.getoption("dist") == "loadgroup":
for item in items:
mark = item.get_closest_marker("xdist_group")
if not mark:
Expand Down Expand Up @@ -356,7 +356,6 @@ def getinfodict() -> WorkerInfo:


def setup_config(config: pytest.Config, basetemp: str | None) -> None:
config.option.loadgroup = config.getvalue("dist") == "loadgroup"
config.option.looponfail = False
config.option.usepdb = False
config.option.dist = "no"
Expand Down
Loading