[pre-commit.ci] pre-commit autoupdate #13475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.11 → v0.11.12](astral-sh/ruff-pre-commit@v0.11.11...v0.11.12) - [github.com/woodruffw/zizmor-pre-commit: v1.8.0 → v1.9.0](zizmorcore/zizmor-pre-commit@v1.8.0...v1.9.0) - [github.com/pre-commit/mirrors-mypy: v1.15.0 → v1.16.0](pre-commit/mirrors-mypy@v1.15.0...v1.16.0)
|
A bunch of new errors from mypy this time. I pushed a commit which fixes them (should be squashed) |
nicoddemus
approved these changes
Jun 3, 2025
| def __enter__(self) -> Self: | ||
| # Type ignored because we basically want the `catch_warnings` generic type | ||
| # parameter to be ourselves but that is not possible(?). | ||
| def __enter__(self) -> Self: # type: ignore[override] |
I think in this case it would be nice to have the two commits landing separately, given the 1st one is automated. What do you think? |
|
This way the first commit won't be clean (won't pass linting). I quickly tried to flip the order but it's not clean either. So easier to squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: