Skip to content

Remove for loops in deviations function body #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krokosik
Copy link

Description

I am trying to adapt adaptive for sequential operations with a relatively fast function. I really love the package and would like to experiment with speeding up the learners themselves. This is a minor change which does not affect the speed much, as interpolators seem to be bottleneck, but since I already implemented it, I figured I'd share it :)

I also noticed the tutorial link in README is broken, so I included it here as it is a tiny change, but can remove it if you'd like.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt
Copy link
Member

Awesome! The list of interpolator objects was for the case where a 2D function returns a 1D vector output I remember. Not sure if that is covered properly by the tests, if so all is good because everything passes 😄

AFK now but will check later.

@krokosik
Copy link
Author

@basnijholt cool, thanky you! I also tested the new function on my data with thousands of points and an assertion of the old function result :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants