Skip to content

Don't copy dataclass methods to the schema. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2020
Merged

Conversation

python-desert
Copy link
Collaborator

Closes #77.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         446    446           
  Branches       69     69           
=====================================
  Hits          446    446

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e9b21...0c9d39e. Read the comment docs.

@python-desert
Copy link
Collaborator Author

This might be fixed by #81

Copy link
Member

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@python-desert python-desert merged commit 6b073af into master Feb 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the dont-copy-methods branch February 24, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected side effects if dump is defined in the data class when using schema.dump
2 participants