Check whether an EncodedURL can be decoded before giving it back #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #153 by fixing only the Hypothesis strategy for
DecodedURL. It doesn't stopencoded_urlsfrom findingEncodedURLvalues which cannot be decoded byDecodedURL. It only catches these values in thedecoded_urlsstrategy.This might be the wrong change to make since it really only hides the fact that not all
EncodedURLvalues can be decoded withDecodedURL. It seems like fixing the actual decoding inDecodedURLwould be better, but I'm not sure how to do that.