Skip to content

Conversation

dbazile
Copy link

@dbazile dbazile commented Jan 12, 2025

This adds an opt-out for the forced path separator escaping added for #373. This fixes an issue where paths are always escaped, making this feature unusable without constant backtracking to remove escapes (see sublimelsp/LSP-pylsp#180).

I don't know how valid the default listed in CONFIGURATION.md is (the default value is whether or not snippets are supported, which always seems to be true) but I can't figure out how better to phrase it.

Demo

demo-fix.webm

References

@ccordoba12
Copy link
Member

Hey @dbazile, I don't think this is the correct approach. If your client supports code snippets, the escapes added to paths by this server need to be handled by it, not by an additional option here.

That's what we do in Spyder, at least:

dir-completions

@dbazile
Copy link
Author

dbazile commented Feb 7, 2025 via email

@ccordoba12
Copy link
Member

Ok, then why don't you disable code snippets? That would avoid the path separator escaping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants