Skip to content

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 1, 2025

For better isolation from the current runtime, run the test in a separate subprocess similarly to test_pending_call_creates_thread.

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Oct 1, 2025
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0cb09f9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139473%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2025
@kumaraditya303 kumaraditya303 marked this pull request as ready for review October 1, 2025 11:53
@ZeroIntensity
Copy link
Member

I'm not sure I understand the rationale here. We already have a test for doing this in a subprocess: test_pending_call_creates_thread.

@kumaraditya303
Copy link
Contributor Author

I'm not sure I understand the rationale here. We already have a test for doing this in a subprocess: test_pending_call_creates_thread.

Yes, but that runs in main interpreter but this runs in a sub-interpreter.

@ZeroIntensity
Copy link
Member

But why do it in a subprocess? We create and destroy subinterpreters in the main process in other tests, don't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants