Skip to content

Conversation

JacobCoffee
Copy link
Member

Description

  • Enables optional (may) starttls for receiving (smptd)

Closes

@JacobCoffee JacobCoffee requested a review from ewdurbin as a code owner March 18, 2025 14:35
@JacobCoffee
Copy link
Member Author

JacobCoffee commented Apr 1, 2025

in e655530 pebble is running

vagrant@salt-master:~$ curl -k https://salt-master.vagrant.psf.io:14000/dir
{
   "keyChange": "https://salt-master.vagrant.psf.io:14000/rollover-account-key",
   "meta": {
      "externalAccountRequired": false,
      "termsOfService": "data:text/plain,Do%20what%20thou%20wilt"
   },
   "newAccount": "https://salt-master.vagrant.psf.io:14000/sign-me-up",
   "newNonce": "https://salt-master.vagrant.psf.io:14000/nonce-plz",
   "newOrder": "https://salt-master.vagrant.psf.io:14000/order-plz",
   "revokeCert": "https://salt-master.vagrant.psf.io:14000/revoke-cert"

but hitting:

2025-04-01 15:15:14,982:ERROR:certbot._internal.log:An unexpected error occurred:
2025-04-01 15:15:14,982:ERROR:certbot._internal.log:requests.exceptions.SSLError: HTTPSConnectionPool(host='salt-master.vagrant.psf.io', port=14000): Max retries exceeded with url: /dir (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)')))

tried with - server: https://salt-master.psf.io:14000/dir and - server: https://localhost:14000/dir and http counterparts

@JacobCoffee JacobCoffee requested a review from ewdurbin May 6, 2025 16:20
@JacobCoffee JacobCoffee requested a review from ewdurbin October 8, 2025 14:07
@JacobCoffee JacobCoffee requested a review from ewdurbin October 8, 2025 19:23
@ewdurbin
Copy link
Member

I had some nit picks (commit by commit) in the pillar data but looks good. I think this is fairly safe to ship since the certificates fetched should only end up being used by the roundup box until we update https://github.com/python/psf-salt/blob/main/salt/haproxy/config/haproxy.cfg.jinja#L100-L103

Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry! forgot this part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for starttls on roundup-tracker.org

2 participants