Push MeshTrait implementation to _ActorMeshRefImpl #553
+310
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#551) Summary: This diffs adds `def slice` method to both `PythonActorMesh` and `PythonActorMeshRef`. With this method, we can: 1. slice a `PythonActorMesh` object into a `PythonActorMeshRef`; 1. slice a `PythonActorMeshRef` into another `PythonActorMeshRef`. Tests are added to demo that we can cast to the sliced mesh ref. Reviewed By: shayne-fletcher Differential Revision: D78292490
Summary: `_ActorMeshRefImpl` is the standin class for `PythonActorMesh` and `PythonActorMeshRef`. This diff stack is working on replacing `_ActorMeshRefImpl` with `PythonActorMesh` and `PythonActorMeshRef`. Compared to `PythonActorMesh` and `PythonActorMeshRef`, one method `_ActorMeshRefImpl` is missing is the `def slice` method. Lacking of this method blocks to do a drop-in replacement. This diff pushes the `MeshTrait` implementation to `_ActorMeshRefImpl`. In this way, `_ActorMeshRefImpl` will have `the slice` method from `MeshTrait`. Differential Revision: D78300586
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78300586 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jul 16, 2025
Summary: `_ActorMeshRefImpl` is the standin class for `PythonActorMesh` and `PythonActorMeshRef`. This diff stack is working on replacing `_ActorMeshRefImpl` with `PythonActorMesh` and `PythonActorMeshRef`. Compared to `PythonActorMesh` and `PythonActorMeshRef`, one method `_ActorMeshRefImpl` is missing is the `def slice` method. Lacking of this method blocks to do a drop-in replacement. This diff pushes the `MeshTrait` implementation to `_ActorMeshRefImpl`. In this way, `_ActorMeshRefImpl` will have `the slice` method from `MeshTrait`. Differential Revision: D78300586
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jul 16, 2025
Summary: `_ActorMeshRefImpl` is the standin class for `PythonActorMesh` and `PythonActorMeshRef`. This diff stack is working on replacing `_ActorMeshRefImpl` with `PythonActorMesh` and `PythonActorMeshRef`. Compared to `PythonActorMesh` and `PythonActorMeshRef`, one method `_ActorMeshRefImpl` is missing is the `def slice` method. Lacking of this method blocks to do a drop-in replacement. This diff pushes the `MeshTrait` implementation to `_ActorMeshRefImpl`. In this way, `_ActorMeshRefImpl` will have `the slice` method from `MeshTrait`. Differential Revision: D78300586
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jul 16, 2025
Summary: `_ActorMeshRefImpl` is the standin class for `PythonActorMesh` and `PythonActorMeshRef`. This diff stack is working on replacing `_ActorMeshRefImpl` with `PythonActorMesh` and `PythonActorMeshRef`. Compared to `PythonActorMesh` and `PythonActorMeshRef`, one method `_ActorMeshRefImpl` is missing is the `def slice` method. Lacking of this method blocks to do a drop-in replacement. This diff pushes the `MeshTrait` implementation to `_ActorMeshRefImpl`. In this way, `_ActorMeshRefImpl` will have `the slice` method from `MeshTrait`. Differential Revision: D78300586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
_ActorMeshRefImplis the standin class forPythonActorMeshandPythonActorMeshRef. This diff stack is working on replacing_ActorMeshRefImplwithPythonActorMeshandPythonActorMeshRef.Compared to
PythonActorMeshandPythonActorMeshRef, one method_ActorMeshRefImplis missing is thedef slicemethod. Lacking of this method blocks to do a drop-in replacement.This diff pushes the
MeshTraitimplementation to_ActorMeshRefImpl. In this way,_ActorMeshRefImplwill havethe slicemethod fromMeshTrait.Differential Revision: D78300586