Lift the send-to-actor
logic from _ActorMeshRefImpl
to ActorIdRef
#555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RDMAManger
andDebugManager
have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking_ActorMeshRefImpl
's implementation. This is blocking the migration from_ActorMeshRefImpl
toPythonActorMesh
, because we cannot create a mesh solely based on its actor ID.To unblock, this diff lifts the
send-to-actor
logic from_ActorMeshRefImpl
toActorIdRef
, so it is decoupled from_ActorMeshRefImpl
andActorMeshRef
.Differential Revision: D78302352