Skip to content

Lift the send-to-actor logic from _ActorMeshRefImpl to ActorIdRef #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pzhan9
Copy link
Contributor

@pzhan9 pzhan9 commented Jul 16, 2025

Summary:
RDMAManger and DebugManager have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking _ActorMeshRefImpl's implementation. This is blocking the migration from _ActorMeshRefImpl to PythonActorMesh, because we cannot create a mesh solely based on its actor ID.

To unblock, this diff lifts the send-to-actor logic from _ActorMeshRefImpl to ActorIdRef, so it is decoupled from _ActorMeshRefImpl and ActorMeshRef.

Differential Revision: D78302352

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78302352

pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Jul 16, 2025
…f` (pytorch-labs#555)

Summary:

`RDMAManger` and `DebugManager` have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking `_ActorMeshRefImpl`'s implementation. This is blocking the migration from `_ActorMeshRefImpl` to `PythonActorMesh`, because we cannot create a mesh solely based on its actor ID. 

To unblock, this diff lifts the `send-to-actor` logic from  `_ActorMeshRefImpl` to `ActorIdRef`, so it is decoupled from `_ActorMeshRefImpl` and `ActorMeshRef`.

Differential Revision: D78302352
pzhan9 added a commit to pzhan9/monarch-1 that referenced this pull request Jul 16, 2025
…f` (pytorch-labs#555)

Summary:

`RDMAManger` and `DebugManager` have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking `_ActorMeshRefImpl`'s implementation. This is blocking the migration from `_ActorMeshRefImpl` to `PythonActorMesh`, because we cannot create a mesh solely based on its actor ID. 

To unblock, this diff lifts the `send-to-actor` logic from  `_ActorMeshRefImpl` to `ActorIdRef`, so it is decoupled from `_ActorMeshRefImpl` and `ActorMeshRef`.

Differential Revision: D78302352
pzhang and others added 2 commits July 16, 2025 14:01
Differential Revision: D78300586
…f` (pytorch-labs#555)

Summary:
Pull Request resolved: pytorch-labs#555

`RDMAManger` and `DebugManager` have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking `_ActorMeshRefImpl`'s implementation. This is blocking the migration from `_ActorMeshRefImpl` to `PythonActorMesh`, because we cannot create a mesh solely based on its actor ID.

To unblock, this diff lifts the `send-to-actor` logic from  `_ActorMeshRefImpl` to `ActorIdRef`, so it is decoupled from `_ActorMeshRefImpl` and `ActorMeshRef`.

Differential Revision: D78302352
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78302352

@pzhan9 pzhan9 force-pushed the export-D78302352 branch from cb9e0d2 to 3556e44 Compare July 17, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants