Lift the send-to-actor logic from _ActorMeshRefImpl to ActorIdRef
#555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78302352 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jul 16, 2025
…f` (pytorch-labs#555) Summary: `RDMAManger` and `DebugManager` have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking `_ActorMeshRefImpl`'s implementation. This is blocking the migration from `_ActorMeshRefImpl` to `PythonActorMesh`, because we cannot create a mesh solely based on its actor ID. To unblock, this diff lifts the `send-to-actor` logic from `_ActorMeshRefImpl` to `ActorIdRef`, so it is decoupled from `_ActorMeshRefImpl` and `ActorMeshRef`. Differential Revision: D78302352
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jul 16, 2025
…f` (pytorch-labs#555) Summary: `RDMAManger` and `DebugManager` have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking `_ActorMeshRefImpl`'s implementation. This is blocking the migration from `_ActorMeshRefImpl` to `PythonActorMesh`, because we cannot create a mesh solely based on its actor ID. To unblock, this diff lifts the `send-to-actor` logic from `_ActorMeshRefImpl` to `ActorIdRef`, so it is decoupled from `_ActorMeshRefImpl` and `ActorMeshRef`. Differential Revision: D78302352
Differential Revision: D78300586
…f` (pytorch-labs#555) Summary: Pull Request resolved: pytorch-labs#555 `RDMAManger` and `DebugManager` have use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking `_ActorMeshRefImpl`'s implementation. This is blocking the migration from `_ActorMeshRefImpl` to `PythonActorMesh`, because we cannot create a mesh solely based on its actor ID. To unblock, this diff lifts the `send-to-actor` logic from `_ActorMeshRefImpl` to `ActorIdRef`, so it is decoupled from `_ActorMeshRefImpl` and `ActorMeshRef`. Differential Revision: D78302352
|
This pull request was exported from Phabricator. Differential Revision: D78302352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RDMAMangerandDebugManagerhave use cases that need to send messages directly to an actor based on its actor id, instead of to a mesh. Currently the "send-to-actor" function is piggybacking_ActorMeshRefImpl's implementation. This is blocking the migration from_ActorMeshRefImpltoPythonActorMesh, because we cannot create a mesh solely based on its actor ID.To unblock, this diff lifts the
send-to-actorlogic from_ActorMeshRefImpltoActorIdRef, so it is decoupled from_ActorMeshRefImplandActorMeshRef.Differential Revision: D78302352