[monarch] don't rotate logs, even daily #577
Closed
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue. Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)! [ghstack-poisoned]
This was referenced Jul 18, 2025
meta-cla
bot
added
the
CLA Signed
suo
added a commit
that referenced
this pull request
Jul 18, 2025
this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue. Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)! ghstack-source-id: 296986815 Pull Request resolved: #577
|
This pull request was exported from Phabricator. Differential Revision: D78531468 |
this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue. Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)! [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jul 18, 2025
Pull Request resolved: #577 this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue. ghstack-source-id: 296989648 @exported-using-ghexport Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)!
|
This pull request was exported from Phabricator. Differential Revision: D78531468 |
this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue. Differential Revision: [D78531468](https://our.internmc.facebook.com/intern/diff/D78531468/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78531468/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78531468 |
|
This pull request has been merged in cdce966. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
this is quite annoying to deal with in the logarithm UI. Let's avoid rotating logs unless we have a proven issue.
Differential Revision: D78531468
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!