Define blocking variants of everything in terms of non-blocking variant. #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python. The new approach is to define the entire thing in async and then wrap it in a future: `Future(async_impl, requires_loop=False)`. If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass `requires_loop=False`, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts. Differential Revision: [D78585722](https://our.internmc.facebook.com/intern/diff/D78585722/) [ghstack-poisoned]
meta-cla
bot
added
the
CLA Signed
zdevito
added a commit
that referenced
this pull request
Jul 19, 2025
This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python. The new approach is to define the entire thing in async and then wrap it in a future: `Future(async_impl, requires_loop=False)`. If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass `requires_loop=False`, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts. Differential Revision: [D78585722](https://our.internmc.facebook.com/intern/diff/D78585722/) ghstack-source-id: 297233471 Pull Request resolved: #585
|
This pull request was exported from Phabricator. Differential Revision: D78585722 |
…cking variant." This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python. The new approach is to define the entire thing in async and then wrap it in a future: `Future(async_impl, requires_loop=False)`. If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass `requires_loop=False`, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts. Differential Revision: [D78585722](https://our.internmc.facebook.com/intern/diff/D78585722/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 19, 2025
Pull Request resolved: #585 This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python. The new approach is to define the entire thing in async and then wrap it in a future: `Future(async_impl, requires_loop=False)`. If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass `requires_loop=False`, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts. ghstack-source-id: 297244019 @exported-using-ghexport Differential Revision: [D78585722](https://our.internmc.facebook.com/intern/diff/D78585722/)
|
This pull request was exported from Phabricator. Differential Revision: D78585722 |
…cking variant." This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python. The new approach is to define the entire thing in async and then wrap it in a future: `Future(async_impl, requires_loop=False)`. If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass `requires_loop=False`, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts. Differential Revision: [D78585722](https://our.internmc.facebook.com/intern/diff/D78585722/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 19, 2025
Pull Request resolved: #585 This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python. The new approach is to define the entire thing in async and then wrap it in a future: `Future(async_impl, requires_loop=False)`. If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass `requires_loop=False`, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts. ghstack-source-id: 297251177 @exported-using-ghexport Differential Revision: [D78585722](https://our.internmc.facebook.com/intern/diff/D78585722/)
|
This pull request was exported from Phabricator. Differential Revision: D78585722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This uses the PyPythonTask functionality developed in the last diff to delete all the _blocking variants of exposing tokio async work to Python.
The new approach is to define the entire thing in async and then wrap it in a future:
Future(async_impl, requires_loop=False).If async_impl only awaits on (1) PythonTask objects, and (2) other coroutine functions, then it is correct to pass
requires_loop=False, which keeps execution speed the same as the blocking version. Otherwise, pass requires_loop=True and the code will work correctly in both async and sync contexts.Differential Revision: D78585722