Skip to content

at least show something when init fails #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

highker
Copy link

@highker highker commented Jul 19, 2025

Summary: The goal is to show why __init__ fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation.

Differential Revision: D78606675

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 19, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78606675

highker pushed a commit to highker/monarch that referenced this pull request Jul 20, 2025
Summary:

The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation.

Reviewed By: suo

Differential Revision: D78606675
@highker highker force-pushed the export-D78606675 branch from 52fcb29 to ee784fb Compare July 20, 2025 21:45
highker pushed a commit to highker/monarch that referenced this pull request Jul 20, 2025
Summary:

The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation.

Reviewed By: suo

Differential Revision: D78606675
@highker highker force-pushed the export-D78606675 branch from ee784fb to adafb27 Compare July 20, 2025 21:46
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78606675

highker pushed a commit to highker/monarch that referenced this pull request Jul 20, 2025
Summary:
Pull Request resolved: pytorch-labs#586

The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation.

Reviewed By: suo

Differential Revision: D78606675
@highker highker force-pushed the export-D78606675 branch from adafb27 to fde0e2f Compare July 20, 2025 21:53
Summary:
Pull Request resolved: pytorch-labs#586

The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation.

Reviewed By: suo

Differential Revision: D78606675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78606675

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 250c91c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants