at least show something when init fails #586
Closed
+41
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78606675 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 20, 2025
Summary: The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation. Reviewed By: suo Differential Revision: D78606675
highker
force-pushed
the
export-D78606675
branch
from
52fcb29 to
ee784fb
Compare
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 20, 2025
Summary: The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation. Reviewed By: suo Differential Revision: D78606675
highker
force-pushed
the
export-D78606675
branch
from
ee784fb to
adafb27
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78606675 |
highker
pushed a commit
to highker/monarch
that referenced
this pull request
Jul 20, 2025
Summary: Pull Request resolved: pytorch-labs#586 The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation. Reviewed By: suo Differential Revision: D78606675
highker
force-pushed
the
export-D78606675
branch
from
adafb27 to
fde0e2f
Compare
Summary: Pull Request resolved: pytorch-labs#586 The goal is to show why `__init__` fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation. Reviewed By: suo Differential Revision: D78606675
|
This pull request was exported from Phabricator. Differential Revision: D78606675 |
highker
force-pushed
the
export-D78606675
branch
from
fde0e2f to
73a6590
Compare
|
This pull request has been merged in 250c91c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The goal is to show why
__init__fails when creating a actor mesh. This is not a proper fix as the right solution should follow T229200522. I was halfway into the issue until I found T229200522. So pzhan9, I will leave it to you to get the right fix. This diff is a mitigation.Differential Revision: D78606675