: avoid panic #605
Open
: avoid panic #605
+31
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78681418 |
shayne-fletcher
force-pushed
the
export-D78681418
branch
from
afa80f6 to
246af5b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78681418 |
shayne-fletcher
force-pushed
the
export-D78681418
branch
from
246af5b to
d3beb8c
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
it's reasonable for `event_loop.call_method0("run_forever")` to return with error. therefore, do not `.unwrap()`
Differential Revision: D78681418
|
This pull request was exported from Phabricator. Differential Revision: D78681418 |
shayne-fletcher
force-pushed
the
export-D78681418
branch
from
d3beb8c to
2b9a98b
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
it's reasonable for `event_loop.call_method0("run_forever")` to return with error. therefore, do not `.unwrap()`
Differential Revision: D78681418
|
This pull request was exported from Phabricator. Differential Revision: D78681418 |
shayne-fletcher
force-pushed
the
export-D78681418
branch
from
2b9a98b to
a2c4338
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
it's reasonable for `event_loop.call_method0("run_forever")` to return with error. therefore, do not `.unwrap()`
Differential Revision: D78681418
|
This pull request was exported from Phabricator. Differential Revision: D78681418 |
Summary: just a lint Reviewed By: highker Differential Revision: D78675226
Summary: lints Reviewed By: highker Differential Revision: D78675223
Summary: lints Reviewed By: allenwang28 Differential Revision: D78677315
Summary: lint Reviewed By: highker Differential Revision: D78677654
Summary:
it's reasonable for `event_loop.call_method0("run_forever")` to return with error. therefore, do not `.unwrap()`
Differential Revision: D78681418
shayne-fletcher
force-pushed
the
export-D78681418
branch
from
a2c4338 to
beec257
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78681418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D78681418