Allow passing a lamda to from_alloc to set env vars based on MonarchContext #622
+362
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78602523 |
jayasi
added a commit
to jayasi/monarch
that referenced
this pull request
Jul 22, 2025
…ontext (pytorch-labs#622) Summary: The from_alloc method now takes an optional Callable At a high level: ``` def setup_defined_in_user_code(ctx: MonarchCtx) -> None """ user code logic which sets up env vars """ ... allocator = MastAllocator(my_job) alloc = allocator.allocate(spec) proc_mesh = await ProcMesh.from_alloc(alloc, setup_defined_in_user_code) // this will call the SetupActor behind the scenes which takes the setup_defined_in_user_code method user_code_actor = await proc_mesh.spawn(UserCodeActor) .... Differential Revision: D78602523
jayasi
added a commit
to jayasi/monarch
that referenced
this pull request
Jul 22, 2025
…ontext (pytorch-labs#622) Summary: The from_alloc method now takes an optional Callable At a high level: ``` def setup_defined_in_user_code(ctx: MonarchCtx) -> None """ user code logic which sets up env vars """ ... allocator = MastAllocator(my_job) alloc = allocator.allocate(spec) proc_mesh = await ProcMesh.from_alloc(alloc, setup_defined_in_user_code) // this will call the SetupActor behind the scenes which takes the setup_defined_in_user_code method user_code_actor = await proc_mesh.spawn(UserCodeActor) .... Differential Revision: D78602523
|
This pull request was exported from Phabricator. Differential Revision: D78602523 |
jayasi
added a commit
to jayasi/monarch
that referenced
this pull request
Jul 23, 2025
…ontext (pytorch-labs#622) Summary: The from_alloc method now takes an optional Callable At a high level: ``` def setup_defined_in_user_code(ctx: MonarchCtx) -> None """ user code logic which sets up env vars """ ... allocator = MastAllocator(my_job) alloc = allocator.allocate(spec) proc_mesh = await ProcMesh.from_alloc(alloc, setup_defined_in_user_code) // this will call the SetupActor behind the scenes which takes the setup_defined_in_user_code method user_code_actor = await proc_mesh.spawn(UserCodeActor) .... Differential Revision: D78602523
jayasi
added a commit
to jayasi/monarch
that referenced
this pull request
Jul 23, 2025
…ontext (pytorch-labs#622) Summary: The from_alloc method now takes an optional Callable At a high level: ``` def setup_defined_in_user_code(ctx: MonarchCtx) -> None """ user code logic which sets up env vars """ ... allocator = MastAllocator(my_job) alloc = allocator.allocate(spec) proc_mesh = await ProcMesh.from_alloc(alloc, setup_defined_in_user_code) // this will call the SetupActor behind the scenes which takes the setup_defined_in_user_code method user_code_actor = await proc_mesh.spawn(UserCodeActor) .... Differential Revision: D78602523
|
This pull request was exported from Phabricator. Differential Revision: D78602523 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78602523 |
jayasi
added a commit
to jayasi/monarch
that referenced
this pull request
Jul 23, 2025
…ontext (pytorch-labs#622) Summary: Pull Request resolved: pytorch-labs#622 The from_alloc method now takes an optional Callable At a high level: ``` def setup_defined_in_user_code(ctx: MonarchCtx) -> None """ user code logic which sets up env vars """ ... allocator = MastAllocator(my_job) alloc = allocator.allocate(spec) proc_mesh = await ProcMesh.from_alloc(alloc, setup_defined_in_user_code) // this will call the SetupActor behind the scenes which takes the setup_defined_in_user_code method user_code_actor = await proc_mesh.spawn(UserCodeActor) .... Differential Revision: D78602523
…ontext (pytorch-labs#622) Summary: The from_alloc method now takes an optional Callable At a high level: ``` def setup_defined_in_user_code(ctx: MonarchCtx) -> None """ user code logic which sets up env vars """ ... allocator = MastAllocator(my_job) alloc = allocator.allocate(spec) proc_mesh = await ProcMesh.from_alloc(alloc, setup_defined_in_user_code) // this will call the SetupActor behind the scenes which takes the setup_defined_in_user_code method user_code_actor = await proc_mesh.spawn(UserCodeActor) .... Reviewed By: highker Differential Revision: D78602523
|
This pull request was exported from Phabricator. Differential Revision: D78602523 |
|
This pull request has been merged in ee55be1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The from_alloc method now takes an optional Callable
At a high level: