Enhance structured logging initialization and test coverage #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Updated `tritonparse.structured_logging.init` to accept an `enable_trace_launch` parameter, allowing for improved logging capabilities. - Modified test files to utilize the new logging feature and verify event type counts in generated log files, ensuring accurate tracking of 'launch' and 'compilation' events. - Added checks in `test_tritonparse.py` to assert the expected counts of log events, enhancing test robustness. These changes aim to improve the logging functionality and ensure comprehensive testing of the logging behavior.
Summary: - Introduced helper methods to streamline kernel creation, execution, and log verification in the test suite. - Enhanced the test workflow by separating concerns into dedicated methods for setting up directories, generating test data, and verifying log outputs. - Updated the `test_whole_workflow` method to utilize the new helper methods, improving readability and maintainability. - Added assertions to verify event counts and parsing output, ensuring comprehensive testing of the unified_parse functionality. These changes aim to enhance the organization and robustness of the test suite, facilitating easier future modifications and debugging.
facebook-github-bot
added
the
CLA Signed
…ity and functionality Summary: - Consolidated kernel creation and execution into the `test_whole_workflow` method, enhancing readability. - Removed redundant helper methods and integrated their logic directly into the test, streamlining the workflow. - Added assertions to verify the existence of log files and event counts, ensuring comprehensive testing of the unified_parse functionality. - Simplified setup and data generation processes within the test, improving maintainability. These changes aim to enhance the organization and robustness of the test suite, facilitating easier future modifications and debugging.
davidberard98
approved these changes
Jul 18, 2025
| @@ -981,13 +981,16 @@ def init_basic(trace_folder: Optional[str] = None): | |||
| maybe_enable_trace_launch() | |||
|
|
|||
|
|
|||
| def init(trace_folder: Optional[str] = None): | |||
| def init(trace_folder: Optional[str] = None, enable_trace_launch: bool = False): | |||
| """ | |||
| This function is a wrapper around init_basic() that also setup the compilation listener. | |||
|
|
|||
| Args: | |||
| trace_folder (Optional[str]): The folder to store the trace files. | |||
There was a problem hiding this comment.
nit: description for enable_trace_launch
There was a problem hiding this comment.
ah, sorry, didn't see this comment. Will fix in next BE PR for comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
tritonparse.structured_logging.initto accept anenable_trace_launchparameter, allowing for improved logging capabilities.test_tritonparse.pyto assert the expected counts of log events, enhancing test robustness.These changes aim to improve the logging functionality and ensure comprehensive testing of the logging behavior.