Make fp8 ck gemm support both OCP and FNUZ FP8 #4728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D80138910 |
Alkaid-Benetnash
force-pushed
the
export-D80138910
branch
from
19b0812 to
64fc78c
Compare
Alkaid-Benetnash
added a commit
to Alkaid-Benetnash/FBGEMM-1
that referenced
this pull request
Aug 19, 2025
Summary: X-link: facebookresearch/FBGEMM#1751 Use type info from ck to tell whether we are using OCP FP8 or FNUZ FP8. Updated fp8_rowwise and fp8_rowwise_preshuffle wrappers. Note that header macros like CK_USE_OCP_FP8 and CK_USE_FNUZ_FP8 could be both defined (if need to support multiple architectures). Reviewed By: mxz297 Differential Revision: D80138910
|
This pull request was exported from Phabricator. Differential Revision: D80138910 |
Alkaid-Benetnash
force-pushed
the
export-D80138910
branch
from
64fc78c to
b403940
Compare
Alkaid-Benetnash
added a commit
to Alkaid-Benetnash/FBGEMM-1
that referenced
this pull request
Aug 26, 2025
Summary: X-link: facebookresearch/FBGEMM#1751 Use type info from ck to tell whether we are using OCP FP8 or FNUZ FP8. Updated fp8_rowwise and fp8_rowwise_preshuffle wrappers. Note that header macros like CK_USE_OCP_FP8 and CK_USE_FNUZ_FP8 could be both defined (if need to support multiple architectures). Reviewed By: mxz297 Differential Revision: D80138910
Alkaid-Benetnash
force-pushed
the
export-D80138910
branch
from
b403940 to
6ec6308
Compare
Alkaid-Benetnash
added a commit
to Alkaid-Benetnash/FBGEMM-1
that referenced
this pull request
Aug 26, 2025
Summary: X-link: facebookresearch/FBGEMM#1751 Use type info from ck to tell whether we are using OCP FP8 or FNUZ FP8. Updated fp8_rowwise and fp8_rowwise_preshuffle wrappers. Note that header macros like CK_USE_OCP_FP8 and CK_USE_FNUZ_FP8 could be both defined (if need to support multiple architectures). Reviewed By: mxz297 Differential Revision: D80138910
|
This pull request was exported from Phabricator. Differential Revision: D80138910 |
Alkaid-Benetnash
added a commit
to Alkaid-Benetnash/FBGEMM-1
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: pytorch#4728 X-link: facebookresearch/FBGEMM#1751 Use type info from ck to tell whether we are using OCP FP8 or FNUZ FP8. Updated fp8_rowwise and fp8_rowwise_preshuffle wrappers. Note that header macros like CK_USE_OCP_FP8 and CK_USE_FNUZ_FP8 could be both defined (if need to support multiple architectures). Reviewed By: mxz297 Differential Revision: D80138910
Alkaid-Benetnash
force-pushed
the
export-D80138910
branch
from
6ec6308 to
5afcf65
Compare
Summary: Pull Request resolved: pytorch#4728 X-link: facebookresearch/FBGEMM#1751 Use type info from ck to tell whether we are using OCP FP8 or FNUZ FP8. Updated fp8_rowwise and fp8_rowwise_preshuffle wrappers. Note that header macros like CK_USE_OCP_FP8 and CK_USE_FNUZ_FP8 could be both defined (if need to support multiple architectures). Reviewed By: mxz297 Differential Revision: D80138910
|
This pull request was exported from Phabricator. Differential Revision: D80138910 |
Alkaid-Benetnash
force-pushed
the
export-D80138910
branch
from
5afcf65 to
43db625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1751
Use type info from ck to tell whether we are using OCP FP8 or FNUZ FP8.
Updated fp8_rowwise and fp8_rowwise_preshuffle wrappers.
Note that header macros like CK_USE_OCP_FP8 and CK_USE_FNUZ_FP8 could be both defined (if need to support multiple architectures).
Reviewed By: mxz297
Differential Revision: D80138910