Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 9, 2025

Summary

Tag constants after quantization.

If we tag before quantization, the graph is mutated and tags are lost.

Test plan

CI (lora test)

Copy link

pytorch-bot bot commented Oct 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14955

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit afec819 with merge base d4129b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link

meta-codesync bot commented Oct 9, 2025

@lucylq has imported this pull request. If you are a Meta employee, you can view this in D84278836.

@lucylq lucylq force-pushed the lfq.tag-constants-after-quant branch 2 times, most recently from fc63fc3 to 8f84f24 Compare October 9, 2025 19:43
@lucylq lucylq force-pushed the lfq.tag-constants-after-quant branch from 8f84f24 to afec819 Compare October 9, 2025 19:56
@lucylq lucylq marked this pull request as ready for review October 9, 2025 20:10
@lucylq lucylq requested a review from jackzhxng as a code owner October 9, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant