reduce verbosity of some dynolog warnings #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: User reports are that these will appear frequently when used in OSS with KINETO_USE_DAEON=1 Differential Revision: D54347978
|
This pull request was exported from Phabricator. Differential Revision: D54347978 |
aaronenyeshi
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
This looks okay to me, how often so these error messages occur? also cc @briancoutinho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
User reports are that these will appear frequently when used in OSS with
KINETO_USE_DAEON=1
Differential Revision: D54347978