Skip to content

Conversation

jeanschmidt
Copy link
Contributor

  • Highlight hud autorevert decisions on main hud table with a different background
  • Add a banner on hover for autoreverted commits on main hud table
  • Special background for signals that are flagged to autorevert, making them easier to identify
  • Adds a banner on commit page about the autorevert and the identified signals

@pytorch-bot pytorch-bot bot added the ci-no-td label Oct 6, 2025
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Oct 8, 2025 11:49pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@jeanschmidt
Copy link
Contributor Author

Screenshot 2025-10-06 at 18 48 30 Screenshot 2025-10-06 at 18 48 12

Signed-off-by: Jean Schmidt <[email protected]>
@jeanschmidt
Copy link
Contributor Author

jeanschmidt commented Oct 6, 2025

FYI: test error is unrelated to the change, it is a library that changed behaviour and I am not managing this in this PR

@izaitsevfb
Copy link
Contributor

izaitsevfb commented Oct 6, 2025

Several notes:

  1. Please address accidental changes.

  2. The job marking logic doesn't work when grouping is enabled:
    image
    image
    please extract the common logic that determines if job should be marked and reuse it for both codepaths, also check other settings, like failures monsterization.

  3. the red border is very similar to "blocks viable strict". maybe let's choose another color to avoid confusion?

    image vs image

@jeanschmidt
Copy link
Contributor Author

@izaitsevfb

Please address accidental changes.

Note it wasn't a accidental changes, just gave up on fixing the test for the newer version of the library. End up updating anyway.

The job marking logic doesn't work when grouping is enabled:
image
image
please extract the common logic that determines if job should be marked and reuse it for both codepaths, also check other settings, like failures monsterization.

Yeah, ok, good point, extracted the logic and reused for both the grouped and expanded views, I wasn't going to support the expanded views, but I guess this is a good point that support it.

the red border is very similar to "blocks viable strict". maybe let's choose another color to avoid confusion?

changed to orange

}
>
{job.name}
{isAutorevert && " ⚠️ (triggered autorevert)"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where this is shown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is on our tooltip

href={job.htmlUrl}
target="_blank"
rel="noreferrer"
style={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ideally this should be css classes instead of inline styles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one was hard to make it work :(

@jeanschmidt jeanschmidt closed this Oct 8, 2025
@jeanschmidt
Copy link
Contributor Author

OK, it should be functionally correct now.

  • marks the commit flagged to revert with a different background;
  • marks the group that have a job that is triggering autorevert with a yellow background;
  • no confusions on multiple tooltip one in top of the other;
  • marks individual jobs that got blamed to autorevert (one caveat, we only have the beginning of the signal, so I also filter by jobs with failure status, not optimal, but sufficient);
  • tooltip on the group flag the jobs that are failing and are responsible for autorevert with red, bold and a alert;
  • toltip on the job flag give a brief notice if it is blaming autorevert;
  • there is a banner on the commit if it was autoreverted with notes pointing to the jobs and a link to them;

// Since we don't have job IDs in the table, we can't create direct job links
job_url: undefined,
// Try to create a HUD URL using the signal key as a filter
hud_url: signalKey
Copy link
Contributor

@izaitsevfb izaitsevfb Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work, signal key is not a substring of HUD job name

Copy link
Contributor

@izaitsevfb izaitsevfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still overcomplicated and:

pointing to the jobs and a link to them;

won't work

but let's fix and improve in the follow up prs, as it provides immediate utility and I'd like it in sooner rather than later.

@izaitsevfb izaitsevfb merged commit 53a1dce into main Oct 8, 2025
5 checks passed
@izaitsevfb izaitsevfb deleted the jeanschmidt/hud_revert_info branch October 8, 2025 23:51
@jeanschmidt
Copy link
Contributor Author

Thank you for reviewing and providing improvements. Lets make sure we're keeping track of this so we're not end up forgetting about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants